[GitHub] [ozone] sodonnel commented on a change in pull request #2718: HDDS-5833: EC: Fix TestRootedOzoneFileSystem.testBucketDefaultsShouldBeInheritedToFileForEC failure in branch

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #2718:
URL: https://github.com/apache/ozone/pull/2718#discussion_r723513484



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
##########
@@ -1557,7 +1557,7 @@ public void testBucketDefaultsShouldBeInheritedToFileForEC()
     builder.setBucketLayout(BucketLayout.LEGACY);
     builder.setDefaultReplicationConfig(
         new DefaultReplicationConfig(ReplicationType.EC,
-            new ECReplicationConfig(3, 2)));
+            new ECReplicationConfig("RS-3-2-1024")));

Review comment:
       Just for info, you can also use the new constructor here:
   
   ```
   public ECReplicationConfig(int data, int parity, EcCodec codec,
         int ecChunkSize)
   ```
   
   However the above is fine with me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org