[GitHub] [doris] levy5307 commented on a diff in pull request #18990: [Feature](resource-group) Support alter resource group

["levy5307 (via GitHub)" <gi...@apache.org>]

levy5307 commented on code in PR #18990:
URL: https://github.com/apache/doris/pull/18990#discussion_r1177284632


##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -884,8 +886,11 @@ public void analyze(TQueryOptions tQueryOptions) throws UserException {
                 || parsedStmt instanceof InsertStmt
                 || parsedStmt instanceof CreateTableAsSelectStmt) {
             if (Config.enable_resource_group && context.sessionVariable.enablePipelineEngine()) {
-                analyzer.setResourceGroups(analyzer.getEnv().getResourceGroupMgr()
-                        .getResourceGroup(context.sessionVariable.resourceGroup));
+                ResourceGroup resourceGroup = analyzer.getEnv().getResourceGroupMgr().getResourceGroup(
+                        context.sessionVariable.resourceGroup);
+                List<TPipelineResourceGroup> resourceGroups = Lists.newArrayList();
+                resourceGroups.add(resourceGroup.toThrift());

Review Comment:
   So we should write another func named with `getResourceGroupThrift` to get return value with type of ` List<TPipelineResourceGroup>`. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org