You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wengzhe (via GitHub)" <gi...@apache.org> on 2023/03/28 03:12:46 UTC
[GitHub] [nuttx] wengzhe opened a new pull request, #8915: net/tcp: Reply RST when we cannot receive data
wengzhe opened a new pull request, #8915:
URL: https://github.com/apache/nuttx/pull/8915
## Summary
According to RFC 2525, Section 2.17:
"When an application closes a connection in such a way that it can no longer read any received data, the TCP SHOULD, per section 4.2.2.13 of RFC 1122, send a RST if there is any unread received data, or if any new data is received. "
When our TCP socket is closed (even when the thread has exited), the peer can keep sending data and NuttX keeps replying ACK (we've tried for ~12h). This is not a good behavior (also different from Linux), so send RST instead of ACK for data receiving in FIN_WAIT.
## Impact
TCP, sending RST instead of ACK for data receiving in FIN_WAIT.
## Testing
iperf2, CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8915: net/tcp: Reply RST when we cannot receive data
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #8915:
URL: https://github.com/apache/nuttx/pull/8915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] wengzhe commented on pull request #8915: net/tcp: Reply RST when we cannot receive data
Posted by "wengzhe (via GitHub)" <gi...@apache.org>.
wengzhe commented on PR #8915:
URL: https://github.com/apache/nuttx/pull/8915#issuecomment-1488110762
> @wengzhe please include this Summary message in the commit log message. Including the message initially in the commit log message you don't need to duplicate your effort because it appear automatically in the Summary
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8915: net/tcp: Reply RST when we cannot receive data
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8915:
URL: https://github.com/apache/nuttx/pull/8915#issuecomment-1486893216
@wengzhe please include this Summary message in the commit log message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org