You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/04 03:51:40 UTC
[GitHub] [incubator-iotdb] Alima777 opened a new pull request #1311: [IOTDB-695] Accelerate the count timeseries query
Alima777 opened a new pull request #1311:
URL: https://github.com/apache/incubator-iotdb/pull/1311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1311: [IOTDB-695] Accelerate the count timeseries query
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #1311:
URL: https://github.com/apache/incubator-iotdb/pull/1311#discussion_r435018995
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -692,6 +692,20 @@ public String getStorageGroupName(String path) throws MetadataException {
}
}
+ /**
+ * To calculate the count of timeseries for given prefix path.
+ */
+ public int getAllTimeseriesCount(String prefixPath) throws MetadataException {
+ lock.readLock().lock();
+ try {
+ return mtree.getAllTimeseriesCount(prefixPath);
+ } catch (MetadataException e) {
+ throw new MetadataException(e);
Review comment:
no need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1311: [IOTDB-695] Accelerate the count timeseries query
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1311:
URL: https://github.com/apache/incubator-iotdb/pull/1311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1311: [IOTDB-695] Accelerate the count timeseries query
Posted by GitBox <gi...@apache.org>.
Alima777 commented on a change in pull request #1311:
URL: https://github.com/apache/incubator-iotdb/pull/1311#discussion_r435053658
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -692,6 +692,20 @@ public String getStorageGroupName(String path) throws MetadataException {
}
}
+ /**
+ * To calculate the count of timeseries for given prefix path.
+ */
+ public int getAllTimeseriesCount(String prefixPath) throws MetadataException {
+ lock.readLock().lock();
+ try {
+ return mtree.getAllTimeseriesCount(prefixPath);
+ } catch (MetadataException e) {
+ throw new MetadataException(e);
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org