You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/24 15:58:31 UTC
[GitHub] [airflow] j-y-matsubara opened a new pull request #7854: Add not
solved items to pylint_todo.txt
j-y-matsubara opened a new pull request #7854: Add not solved items to pylint_todo.txt
URL: https://github.com/apache/airflow/pull/7854
This files do not pass pylint
---
Issue link: Document only change, no JIRA issue
Make sure to mark the boxes below before creating PR: [x]
- [ x ] Description above provides context of the change
- [ x ] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
- [ x ] Unit tests coverage for changes (not needed for documentation changes)
- [ x ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ x ] Relevant documentation is updated including usage instructions.
- [ x ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] j-y-matsubara closed pull request #7854: Add not solved
items to pylint_todo.txt
Posted by GitBox <gi...@apache.org>.
j-y-matsubara closed pull request #7854: Add not solved items to pylint_todo.txt
URL: https://github.com/apache/airflow/pull/7854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7854: Add not solved items to
pylint_todo.txt
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7854: Add not solved items to pylint_todo.txt
URL: https://github.com/apache/airflow/pull/7854#issuecomment-603393364
The general approach is that we should fix them rather than add to pylint_todo.txt -> pylint_todo.txt was only supposed to shrink, not grow. can you please fixe those files @j-y-matsubara ? that would be fantastic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] j-y-matsubara commented on issue #7854: Add not solved
items to pylint_todo.txt
Posted by GitBox <gi...@apache.org>.
j-y-matsubara commented on issue #7854: Add not solved items to pylint_todo.txt
URL: https://github.com/apache/airflow/pull/7854#issuecomment-603579735
@potiuk
OK, I understand. I will try it.
The reason I sent this pull request is because when I ran scripts/ci/ci_pylint_main.sh, these items were marked as pylint errors.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7854: Add not
solved items to pylint_todo.txt
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7854: Add not solved items to pylint_todo.txt
URL: https://github.com/apache/airflow/pull/7854#issuecomment-603327636
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services