You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/17 07:44:40 UTC

[GitHub] [incubator-inlong] zk1510 commented on a diff in pull request #4691: [INLONG-3266][Agent] Get local IP when IP in config is not present

zk1510 commented on code in PR #4691:
URL: https://github.com/apache/incubator-inlong/pull/4691#discussion_r899853944


##########
inlong-agent/agent-common/src/test/java/org/apache/inlong/agent/common/TestAgentUtils.java:
##########
@@ -84,4 +84,9 @@ public void testTimeConvertToMillsec() {
         Assert.assertEquals(1620374040000L, AgentUtils.timeStrConvertToMillSec("202105071554", "M"));
     }
 
+    @Test
+    public void testFetchLocalIp() {
+        Assert.assertNotEquals("127.0.0.1",AgentUtils.fetchLocalIp());

Review Comment:
   it's suggested to add a blank before the second parameter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org