You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/08 07:05:36 UTC

[GitHub] [shardingsphere] cheese8 edited a comment on pull request #15868: Make ExecutorServiceManager could be AutoCloseable ( remove the ShutdownHook)

cheese8 edited a comment on pull request #15868:
URL: https://github.com/apache/shardingsphere/pull/15868#issuecomment-1061470961


   > What is the usage to remove `SHUTDOWN_EXECUTOR`?
   
   The original usage is register a delayed shutdown hook, while closing `ExecutorEngine` which cause by `AutoCloseable` using another thread `SHUTDOWN_EXECUTOR` to shutdown the `executorService` asynchronously.
   
   I think it should be break by while closing `ExecutorEngine` and `UserExecutorGroup` which cause by `AutoCloseable` shutdown the `executorService` directly.
   
   What do you think? @terrymanu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org