You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2006/08/26 13:50:45 UTC

Re: svn commit: r21266 - in trunk/subversion: include/private libsvn_ra_svn

rooneg@tigris.org writes:

> Author: rooneg
> Date: Fri Aug 25 14:17:16 2006
> New Revision: 21266

> Note that detecting that sasl_pool has been destroyed by looking at the
> sasl_status variable is safe because it will only ever be changed once we
> hit single threaded mode during shutdown.

If we are relying on that behaviour then it should be documented in
the code, not the log message.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r21266 - in trunk/subversion: include/private libsvn_ra_svn

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 8/26/06, Philip Martin <ph...@codematters.co.uk> wrote:
> rooneg@tigris.org writes:
>
> > Author: rooneg
> > Date: Fri Aug 25 14:17:16 2006
> > New Revision: 21266
>
> > Note that detecting that sasl_pool has been destroyed by looking at the
> > sasl_status variable is safe because it will only ever be changed once we
> > hit single threaded mode during shutdown.
>
> If we are relying on that behaviour then it should be documented in
> the code, not the log message.

Good call, see r21299.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org