[GitHub] [ozone] adoroszlai commented on a diff in pull request #3611: HDDS-7024. Add queue size metric for OM double buffer

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3611:
URL: https://github.com/apache/ozone/pull/3611#discussion_r926461249


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/metrics/OzoneManagerDoubleBufferMetrics.java:
##########
@@ -58,6 +59,9 @@ public class OzoneManagerDoubleBufferMetrics {
       "iteration")
   private MutableGaugeFloat avgFlushTransactionsInOneIteration;
 
+  @Metric(about = "DoubleBuffer queue size.", valueName = "Size")
+  private MutableStat queueSize;

Review Comment:
   Just one question: this metric tracks the number of transactions flushed in the last iteration, so it tracks queue size in "batches", whenever flush happens.  Should we also add another metric to track the queue size as items are being added to the `currentBuffer`?  Or would that be redundant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org