You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/02/04 03:14:30 UTC
Review Request 30579: Added a missing newline in the command executor
output.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30579/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Niklas Nielsen.
Summary (updated)
-----------------
Added a missing newline in the command executor output.
Repository: mesos
Description (updated)
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504
Diff: https://reviews.apache.org/r/30579/diff/
Testing (updated)
-------
make check
Thanks,
Ben Mahler
Re: Review Request 30579: Added a missing newline in the command
executor output.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30579/#review70917
-----------------------------------------------------------
Ship it!
src/launcher/executor.cpp
<https://reviews.apache.org/r/30579/#comment116385>
s/;;/;/
- Niklas Nielsen
On Feb. 3, 2015, 6:14 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30579/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 6:14 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504
>
> Diff: https://reviews.apache.org/r/30579/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 30579: Added a missing newline in the command
executor output.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30579/#review70946
-----------------------------------------------------------
Ship it!
Modulo Niklas' comment.
- Alexander Rukletsov
On Feb. 4, 2015, 2:14 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30579/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:14 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504
>
> Diff: https://reviews.apache.org/r/30579/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>