[GitHub] spark pull request #13218: [SPARK-15440] [Core] [Deploy] Add CSRF Filter for...

[steveloughran <gi...@git.apache.org>]

Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13218#discussion_r67489509
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/rest/RestCsrfPreventionFilter.scala ---
    @@ -0,0 +1,56 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +* See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy.rest
    +
    +import javax.servlet._
    +import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
    +
    +/**
    + * This filter provides protection against cross site request forgery (CSRF)
    + * attacks for REST APIs. Enabling this filter on an endpoint results in the
    + * requirement of all client to send a particular HTTP header (X-XSRF-HEADER)
    + * with every request. In the absense of this header the filter will reject the
    + * attempt as a bad request.
    + */
    +private[spark] class RestCsrfPreventionFilter extends Filter {
    +
    +  import RestCsrfPreventionFilter._
    +
    +  def init(filterConfig: FilterConfig): Unit = {}
    +
    +  def doFilter(
    +      servletRequest: ServletRequest,
    +      servletResponse: ServletResponse,
    +      filterChain: FilterChain): Unit = {
    +    val httpReq = servletRequest.asInstanceOf[HttpServletRequest]
    --- End diff --
    
    to be strict here, there ought to be check for the request being an `HttpServletRequest`. That said, there is no other subclass of `ServletRequest` which is ever seen in the wild.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org