You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2024/02/22 20:46:15 UTC

(superset) branch fix-limit created (now b1450dfc22)

This is an automated email from the ASF dual-hosted git repository.

beto pushed a change to branch fix-limit
in repository https://gitbox.apache.org/repos/asf/superset.git


      at b1450dfc22 fix: no limit in SELECT * for TOP dbs

This branch includes the following new commits:

     new b1450dfc22 fix: no limit in SELECT * for TOP dbs

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: fix: no limit in SELECT * for TOP dbs

Posted by be...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch fix-limit
in repository https://gitbox.apache.org/repos/asf/superset.git

commit b1450dfc22623d03200702a687309b2bb71b1861
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Thu Feb 22 15:45:46 2024 -0500

    fix: no limit in SELECT * for TOP dbs
---
 superset/db_engine_specs/base.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/db_engine_specs/base.py b/superset/db_engine_specs/base.py
index 3b8bb2bd33..5b850913ed 100644
--- a/superset/db_engine_specs/base.py
+++ b/superset/db_engine_specs/base.py
@@ -1438,7 +1438,7 @@ class BaseEngineSpec:  # pylint: disable=too-many-public-methods
 
         qry = select(fields).select_from(text(full_table_name))
 
-        if limit:
+        if limit and cls.allow_limit_clause:
             qry = qry.limit(limit)
         if latest_partition:
             partition_query = cls.where_latest_partition(