You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Yifan Gu <yi...@mesosphere.io> on 2014/06/04 01:13:04 UTC
Review Request 22223: Patch for issue-1312,
added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for
detail
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
Review request for mesos, Adam B, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" fields in the state.json. So that users can get more information about what's going on when master failover happens.
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 563
> > <https://reviews.apache.org/r/22223/diff/2/?file=603297#file603297line563>
> >
> > How about just calling them "unknown_frameworks" or maybe "disconnected_frameworks"? but disconnected is an overloaded term because a framework might be disconnected even when the master doesn't failover.
>
> Yifan Gu wrote:
> Yeah, I see. unknown_frameworks seems better IMO. Because I found that the newly elected master actually "forgets" the framework. Even the framework tried to re-register with the master, the master will reply a FrameworkRegisteredMessage.
>
> I don't know if the registerar will be modified later to help the master memorize the frameworks.
> But for now, unknown_frameworks is great. Thanks! Vinod!
>
> Vinod Kone wrote:
> yup. registrar in the future will store framework infos and hence master will remember them through failovers.
>
> Vinod Kone wrote:
> Actually thinking about it a bit more "unregistered_frameworks" might be more explicit and easy to understand than "unknown_frameworks". What do you think?
I think that makes more sense, thank you, Vinod!
- Yifan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44738
-----------------------------------------------------------
On June 16, 2014, 8:45 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 8:45 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: Patch for issue-1312,
added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for
detail
Posted by Yifan Gu <yi...@mesosphere.io>.
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/master/http.cpp, lines 543-561
> > <https://reviews.apache.org/r/22223/diff/2/?file=603297#file603297line543>
> >
> > How about pushing this into slave model?
Yes, putting the "orphan_tasks" in their parent slaves seems more structural.
So do you mean moving this piece of code into model(const Slave& slave) {}?
But I don't know how to get the "master.frameworks" in that function without changing the interface of the function...
Did I misunderstand what you said?
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp, line 2040
> > <https://reviews.apache.org/r/22223/diff/2/?file=603298#file603298line2040>
> >
> > You probably want to advance the clock here so that the framework re-registers immediately. otherwise, it might take upto a second slowing down this test.
Sweet! Thanks!
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp, line 1941
> > <https://reviews.apache.org/r/22223/diff/2/?file=603298#file603298line1941>
> >
> > kill flags.
Will do.
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp, line 1937
> > <https://reviews.apache.org/r/22223/diff/2/?file=603298#file603298line1937>
> >
> > No need to explicitly create and pass default flags.
Will do.
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 563
> > <https://reviews.apache.org/r/22223/diff/2/?file=603297#file603297line563>
> >
> > How about just calling them "unknown_frameworks" or maybe "disconnected_frameworks"? but disconnected is an overloaded term because a framework might be disconnected even when the master doesn't failover.
Yeah, I see. unknown_frameworks seems better IMO. Because I found that the newly elected master actually "forgets" the framework. Even the framework tried to re-register with the master, the master will reply a FrameworkRegisteredMessage.
I don't know if the registerar will be modified later to help the master memorize the frameworks.
But for now, unknown_frameworks is great. Thanks! Vinod!
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp, line 2068
> > <https://reviews.apache.org/r/22223/diff/2/?file=603298#file603298line2068>
> >
> > nice test!
:D
- Yifan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44738
-----------------------------------------------------------
On June 3, 2014, 11:58 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:58 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" fields in the state.json. So that users can get more information about what's going on when master failover happens.
>
> For the WebUI part, I think that will have Ross to have a look at this later.
>
> Thanks!
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Vinod Kone <vi...@gmail.com>.
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 563
> > <https://reviews.apache.org/r/22223/diff/2/?file=603297#file603297line563>
> >
> > How about just calling them "unknown_frameworks" or maybe "disconnected_frameworks"? but disconnected is an overloaded term because a framework might be disconnected even when the master doesn't failover.
>
> Yifan Gu wrote:
> Yeah, I see. unknown_frameworks seems better IMO. Because I found that the newly elected master actually "forgets" the framework. Even the framework tried to re-register with the master, the master will reply a FrameworkRegisteredMessage.
>
> I don't know if the registerar will be modified later to help the master memorize the frameworks.
> But for now, unknown_frameworks is great. Thanks! Vinod!
>
> Vinod Kone wrote:
> yup. registrar in the future will store framework infos and hence master will remember them through failovers.
Actually thinking about it a bit more "unregistered_frameworks" might be more explicit and easy to understand than "unknown_frameworks". What do you think?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44738
-----------------------------------------------------------
On June 16, 2014, 8:20 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 8:20 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: Patch for issue-1312,
added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for
detail
Posted by Vinod Kone <vi...@gmail.com>.
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/master/http.cpp, lines 543-561
> > <https://reviews.apache.org/r/22223/diff/2/?file=603297#file603297line543>
> >
> > How about pushing this into slave model?
>
> Yifan Gu wrote:
> Yes, putting the "orphan_tasks" in their parent slaves seems more structural.
> So do you mean moving this piece of code into model(const Slave& slave) {}?
>
> But I don't know how to get the "master.frameworks" in that function without changing the interface of the function...
> Did I misunderstand what you said?
I see. Then what you have is good for now.
> On June 4, 2014, 7:12 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 563
> > <https://reviews.apache.org/r/22223/diff/2/?file=603297#file603297line563>
> >
> > How about just calling them "unknown_frameworks" or maybe "disconnected_frameworks"? but disconnected is an overloaded term because a framework might be disconnected even when the master doesn't failover.
>
> Yifan Gu wrote:
> Yeah, I see. unknown_frameworks seems better IMO. Because I found that the newly elected master actually "forgets" the framework. Even the framework tried to re-register with the master, the master will reply a FrameworkRegisteredMessage.
>
> I don't know if the registerar will be modified later to help the master memorize the frameworks.
> But for now, unknown_frameworks is great. Thanks! Vinod!
yup. registrar in the future will store framework infos and hence master will remember them through failovers.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44738
-----------------------------------------------------------
On June 3, 2014, 11:58 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:58 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" fields in the state.json. So that users can get more information about what's going on when master failover happens.
>
> For the WebUI part, I think that will have Ross to have a look at this later.
>
> Thanks!
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: Patch for issue-1312,
added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for
detail
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44738
-----------------------------------------------------------
src/master/http.cpp
<https://reviews.apache.org/r/22223/#comment79246>
How about pushing this into slave model?
src/master/http.cpp
<https://reviews.apache.org/r/22223/#comment79247>
How about just calling them "unknown_frameworks" or maybe "disconnected_frameworks"? but disconnected is an overloaded term because a framework might be disconnected even when the master doesn't failover.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79254>
No need to explicitly create and pass default flags.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79255>
kill flags.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79260>
You probably want to advance the clock here so that the framework re-registers immediately. otherwise, it might take upto a second slowing down this test.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79261>
nice test!
- Vinod Kone
On June 3, 2014, 11:58 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:58 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" fields in the state.json. So that users can get more information about what's going on when master failover happens.
>
> For the WebUI part, I think that will have Ross to have a look at this later.
>
> Thanks!
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44816
-----------------------------------------------------------
Ship it!
Looks great Yifan! Let's get this committed
src/master/http.cpp
<https://reviews.apache.org/r/22223/#comment79356>
Why the typedef?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79355>
s/orphana/orphan/?
- Niklas Nielsen
On June 4, 2014, 5:23 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 5:23 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Adam B <ad...@mesosphere.io>.
> On June 5, 2014, 1:38 p.m., Adam B wrote:
> > Looks great!
> > Have you tested this manually to see the tasks/framework show up in the web ui? Mention that in the Testing section, please.
>
> Yifan Gu wrote:
> Haven't done the js part yet. I think I will need to do some negotiation with Ross.
>
> Yifan Gu wrote:
> Should we ship it now so Ross can make changes on the js/html stuff based on this later, or should I add those js/html stuff now?
I think the js/html changes can probably be a separate review, so we can get this committed first. Just don't resolve the JIRA until both are committed.
Ross may have a different opinion though, so I defer to him for confirmation.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44844
-----------------------------------------------------------
On June 5, 2014, 3:40 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 3:40 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > Looks great!
> > Have you tested this manually to see the tasks/framework show up in the web ui? Mention that in the Testing section, please.
Haven't done the js part yet. I think I will need to do some negotiation with Ross.
- Yifan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44844
-----------------------------------------------------------
On June 5, 2014, 10:40 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 10:40 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > Looks great!
> > Have you tested this manually to see the tasks/framework show up in the web ui? Mention that in the Testing section, please.
>
> Yifan Gu wrote:
> Haven't done the js part yet. I think I will need to do some negotiation with Ross.
Should we ship it now so Ross can make changes on the js/html stuff based on this later, or should I add those js/html stuff now?
- Yifan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44844
-----------------------------------------------------------
On June 5, 2014, 10:40 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 10:40 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > src/master/http.cpp, line 549
> > <https://reviews.apache.org/r/22223/diff/5/?file=604215#file604215line549>
> >
> > I agree with Niklas that it doesn't add much to define a typedef here that's only used once. Go ahead and inline it like:
> > foreachvalue (const hashmap<TaskID, Task*>& tasks, slave->tasks) {
> > Looks like it would still fit in 80 chars anyway.
I have tried that, but that will cause a compiling error
"error: macro "foreachvalue" passed 3 arguments, but takes just 2
foreachvalue (const hashmap<TaskID, Task*>& tasks, slave->tasks) {"
I also have tried
foreachvalue (hashmap<TaskID, Task*>& tasks, slave->tasks)
foreachvalue (hashmap<TaskID, Task*> tasks, slave->tasks)
Same error, very strange.
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > src/tests/master_tests.cpp, line 1925
> > <https://reviews.apache.org/r/22223/diff/5/?file=604216#file604216line1925>
> >
> > s/will be appear/will appear/
Will do.
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > src/tests/master_tests.cpp, lines 1943-1944
> > <https://reviews.apache.org/r/22223/diff/5/?file=604216#file604216line1943>
> >
> > If you just call driver(&sched, &detector); it will fill in the default FwkInfo and credential.
Will do.
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > src/tests/master_tests.cpp, line 1946
> > <https://reviews.apache.org/r/22223/diff/5/?file=604216#file604216line1946>
> >
> > resourceOffers(&driver, _)
Will do.
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > src/tests/master_tests.cpp, line 1954
> > <https://reviews.apache.org/r/22223/diff/5/?file=604216#file604216line1954>
> >
> > statusUpdate(&driver, _)
Will do.
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > src/tests/master_tests.cpp, lines 1992-1993
> > <https://reviews.apache.org/r/22223/diff/5/?file=604216#file604216line1992>
> >
> > Perhaps this frameworkRegisteredMessage FUTURE_PROTOBUF should go down right before Clock::advance, to check that it doesn't happen until after the advance/settle/resume.
> > Also, why isn't it FrameworkReregisteredMessage?
Haha, that's what I found yesterday.
The newly selected master have no knowledge about this framework, so even the framework tries to re-register with the master, the master will reply a FrameworkRegisteredMessage.
And this FrameworkRegisteredMessage is reply to the second trial of the framework (because I dropped the first RegisterFrameworkMessage).
So if I put it before the clock::Advance(), then it can't get the message since the clock is paused, it never retry doReliableRegistration().
> On June 5, 2014, 8:38 p.m., Adam B wrote:
> > src/tests/master_tests.cpp, lines 1976-1979
> > <https://reviews.apache.org/r/22223/diff/5/?file=604216#file604216line1976>
> >
> > Do you want to do any additional validation that !frameworks.empty(), activeFramework's id is the expected default, and !activeTasks.empty() (only 1?). Also verify no orphan_tasks or unknown_frameworks at this point?
Good idea, will do! Thanks!
- Yifan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44844
-----------------------------------------------------------
On June 5, 2014, 6:47 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 6:47 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Adam B <ad...@mesosphere.io>.
> On June 5, 2014, 1:38 p.m., Adam B wrote:
> > src/master/http.cpp, line 549
> > <https://reviews.apache.org/r/22223/diff/5/?file=604215#file604215line549>
> >
> > I agree with Niklas that it doesn't add much to define a typedef here that's only used once. Go ahead and inline it like:
> > foreachvalue (const hashmap<TaskID, Task*>& tasks, slave->tasks) {
> > Looks like it would still fit in 80 chars anyway.
>
> Yifan Gu wrote:
> I have tried that, but that will cause a compiling error
>
> "error: macro "foreachvalue" passed 3 arguments, but takes just 2
> foreachvalue (const hashmap<TaskID, Task*>& tasks, slave->tasks) {"
>
> I also have tried
> foreachvalue (hashmap<TaskID, Task*>& tasks, slave->tasks)
> foreachvalue (hashmap<TaskID, Task*> tasks, slave->tasks)
>
> Same error, very strange.
>
Interesting. Guess the macro isn't smart enough to parse that correctly. Feel free to drop the issue and leave as is. C++11 'auto' might make this easier.
> On June 5, 2014, 1:38 p.m., Adam B wrote:
> > src/tests/master_tests.cpp, lines 1992-1993
> > <https://reviews.apache.org/r/22223/diff/5/?file=604216#file604216line1992>
> >
> > Perhaps this frameworkRegisteredMessage FUTURE_PROTOBUF should go down right before Clock::advance, to check that it doesn't happen until after the advance/settle/resume.
> > Also, why isn't it FrameworkReregisteredMessage?
>
> Yifan Gu wrote:
> Haha, that's what I found yesterday.
> The newly selected master have no knowledge about this framework, so even the framework tries to re-register with the master, the master will reply a FrameworkRegisteredMessage.
>
> And this FrameworkRegisteredMessage is reply to the second trial of the framework (because I dropped the first RegisterFrameworkMessage).
> So if I put it before the clock::Advance(), then it can't get the message since the clock is paused, it never retry doReliableRegistration().
>
>
Makes sense. Carry on. You can drop this issue too.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44844
-----------------------------------------------------------
On June 5, 2014, 3:40 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 3:40 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44844
-----------------------------------------------------------
Looks great!
Have you tested this manually to see the tasks/framework show up in the web ui? Mention that in the Testing section, please.
src/master/http.cpp
<https://reviews.apache.org/r/22223/#comment79402>
I agree with Niklas that it doesn't add much to define a typedef here that's only used once. Go ahead and inline it like:
foreachvalue (const hashmap<TaskID, Task*>& tasks, slave->tasks) {
Looks like it would still fit in 80 chars anyway.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79403>
s/will be appear/will appear/
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79405>
If you just call driver(&sched, &detector); it will fill in the default FwkInfo and credential.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79406>
resourceOffers(&driver, _)
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79408>
statusUpdate(&driver, _)
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79411>
Do you want to do any additional validation that !frameworks.empty(), activeFramework's id is the expected default, and !activeTasks.empty() (only 1?). Also verify no orphan_tasks or unknown_frameworks at this point?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79414>
Perhaps this frameworkRegisteredMessage FUTURE_PROTOBUF should go down right before Clock::advance, to check that it doesn't happen until after the advance/settle/resume.
Also, why isn't it FrameworkReregisteredMessage?
- Adam B
On June 5, 2014, 11:47 a.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 11:47 a.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44981
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22223]
All tests passed.
- Mesos ReviewBot
On June 5, 2014, 11:11 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 11:11 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review45468
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22223]
All tests passed.
- Mesos ReviewBot
On June 11, 2014, 7:34 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 7:34 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unregistered_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review45827
-----------------------------------------------------------
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment80817>
Add EXPECT_CALL(exec, registered) to eliminate gmock warnings.
- Yifan Gu
On June 16, 2014, 8:47 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 8:47 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["unreregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Haven't done the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unregistered_frameworks in state.json
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review45829
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 16, 2014, 8:56 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 8:56 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["unreregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Haven't done the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unregistered_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:56 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Changes
-------
Elimiated uninterested call warnings.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["unreregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Haven't done the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unregistered_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:47 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Summary (updated)
-----------------
MESOS-1312: Added orphan_tasks and unregistered_frameworks in state.json
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["unreregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Haven't done the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:46 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing (updated)
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["unreregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Haven't done the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:46 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing (updated)
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["unreregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Havent' do the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:45 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Havent' do the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:44 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Changes
-------
s/unknown_frameworks/unregistered_frameworks
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description (updated)
-------
Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Havent' do the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:20 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Havent' do the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 11, 2014, 7:34 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Changes
-------
Ignored subsequent updates.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Havent' do the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 5, 2014, 11:11 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Havent' do the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44863
-----------------------------------------------------------
Ship it!
Great job!
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment79462>
registered(&driver, _, _)
- Adam B
On June 5, 2014, 3:40 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 3:40 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Havent' do the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 5, 2014, 10:40 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Changes
-------
Add check for frameworkId at beginning.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing (updated)
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Havent' do the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 5, 2014, 10:15 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Changes
-------
Addressed some comments.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 5, 2014, 6:47 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 5, 2014, 12:23 a.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 5, 2014, 12:17 a.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
src/tests/slave_tests.cpp 479c0c1
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unknown_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 4, 2014, 11:13 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Summary (updated)
-----------------
MESOS-1312: Added orphan_tasks and unknown_frameworks in state.json
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description (updated)
-------
Added orphan_tasks and unknown_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: Patch for issue-1312,
added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for
detail
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 3, 2014, 11:58 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Changes
-------
Remove hashset stuff.
Repository: mesos-git
Description
-------
This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" fields in the state.json. So that users can get more information about what's going on when master failover happens.
For the WebUI part, I think that will have Ross to have a look at this later.
Thanks!
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: Patch for issue-1312,
added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for
detail
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 3, 2014, 11:16 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Repository: mesos-git
Description (updated)
-------
This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" fields in the state.json. So that users can get more information about what's going on when master failover happens.
For the WebUI part, I think that will have Ross to have a look at this later.
Thanks!
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: Patch for issue-1312,
added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for
detail
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 3, 2014, 11:16 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Repository: mesos-git
Description (updated)
-------
This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" fields in the state.json. So that users can get more information about what's going on when master failover happens.
For the WebUI part, I think that will have Ross to have a look at this later.
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
Thanks,
Yifan Gu
Re: Review Request 22223: Patch for issue-1312,
added orphan_tasks: see https://issues.apache.org/jira/browse/MESOS-1312 for
detail
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review44680
-----------------------------------------------------------
src/master/http.cpp
<https://reviews.apache.org/r/22223/#comment79147>
Ehh, I feel that this is an awful name...
- Yifan Gu
On June 3, 2014, 11:13 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:13 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" fields in the state.json. So that users can get more information about what's going on when master failover happens.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["not_yet_reregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
>
>
> Thanks,
>
> Yifan Gu
>
>