You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/28 18:35:15 UTC
[GitHub] [incubator-superset] lilykuang opened a new pull request #9673: [sql] optimize sql query parser
lilykuang opened a new pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634358345
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/65d185f15305a02b18f1a1cbcdb025e960d26492&el=desc) will **decrease** coverage by `5.21%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
- Coverage 70.79% 65.57% -5.22%
==========================================
Files 587 585 -2
Lines 30435 31048 +613
Branches 3152 3277 +125
==========================================
- Hits 21545 20360 -1185
- Misses 8776 10507 +1731
- Partials 114 181 +67
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.36% <ø> (+0.36%)` | :arrow_up: |
| #python | `69.95% <66.66%> (-1.00%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.28% <66.66%> (-0.09%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [289 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [65d185f...7ebf6e3](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634358345
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/65d185f15305a02b18f1a1cbcdb025e960d26492&el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
+ Coverage 70.79% 70.99% +0.20%
==========================================
Files 587 184 -403
Lines 30435 18000 -12435
Branches 3152 0 -3152
==========================================
- Hits 21545 12779 -8766
+ Misses 8776 5221 -3555
+ Partials 114 0 -114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.99% <100.00%> (+0.04%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.28% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-18.67%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.76% <0.00%> (-4.95%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `86.84% <0.00%> (-2.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <0.00%> (-1.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.91% <0.00%> (-0.88%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.62% <0.00%> (-0.51%)` | :arrow_down: |
| ... and [439 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [65d185f...65e4c9d](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634358345
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/65d185f15305a02b18f1a1cbcdb025e960d26492&el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
- Coverage 70.79% 70.34% -0.45%
==========================================
Files 587 585 -2
Lines 30435 31057 +622
Branches 3152 3277 +125
==========================================
+ Hits 21545 21847 +302
- Misses 8776 9098 +322
+ Partials 114 112 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.91% <ø> (+0.19%)` | :arrow_up: |
| #javascript | `59.36% <ø> (+0.36%)` | :arrow_up: |
| #python | `69.89% <66.66%> (-1.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <66.66%> (-0.09%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-32.28%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.20% <0.00%> (-14.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `84.61% <0.00%> (-8.72%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.45% <0.00%> (-8.59%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `86.29% <0.00%> (-7.42%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-4.77%)` | :arrow_down: |
| ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [65d185f...e2e3c9b](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634358345
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/65d185f15305a02b18f1a1cbcdb025e960d26492&el=desc) will **decrease** coverage by `5.18%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
- Coverage 70.79% 65.60% -5.19%
==========================================
Files 587 585 -2
Lines 30435 31057 +622
Branches 3152 3277 +125
==========================================
- Hits 21545 20375 -1170
- Misses 8776 10501 +1725
- Partials 114 181 +67
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.36% <ø> (+0.36%)` | :arrow_up: |
| #python | `70.00% <66.66%> (-0.96%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <66.66%> (-0.09%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [290 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [65d185f...e2e3c9b](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #9673: [sql] optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-620786471
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a52cfcd234aa7d506c5d0ee659492e772940dbba&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
+ Coverage 70.57% 70.63% +0.06%
==========================================
Files 581 182 -399
Lines 30272 17806 -12466
Branches 3078 0 -3078
==========================================
- Hits 21364 12578 -8786
+ Misses 8796 5228 -3568
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.63% <100.00%> (-0.03%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.35% <100.00%> (+0.01%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | | |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | | |
| [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | | |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | | |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | | |
| [...d/src/dashboard/components/InsertComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0luc2VydENvbXBvbmVudFBhbmUuanN4) | | |
| ... and [391 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [a52cfcd...9142502](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634358345
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/65d185f15305a02b18f1a1cbcdb025e960d26492&el=desc) will **decrease** coverage by `0.40%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
- Coverage 70.79% 70.38% -0.41%
==========================================
Files 587 585 -2
Lines 30435 31057 +622
Branches 3152 3277 +125
==========================================
+ Hits 21545 21861 +316
- Misses 8776 9084 +308
+ Partials 114 112 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.91% <ø> (+0.19%)` | :arrow_up: |
| #javascript | `59.36% <ø> (+0.36%)` | :arrow_up: |
| #python | `69.96% <66.66%> (-0.99%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <66.66%> (-0.09%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-32.28%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.20% <0.00%> (-14.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `84.61% <0.00%> (-8.72%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.45% <0.00%> (-8.59%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `86.29% <0.00%> (-7.42%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-4.77%)` | :arrow_down: |
| ... and [193 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [65d185f...e2e3c9b](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9673: [sql] optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-620786471
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a52cfcd234aa7d506c5d0ee659492e772940dbba&el=desc) will **decrease** coverage by `4.80%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
- Coverage 70.57% 65.76% -4.81%
==========================================
Files 581 581
Lines 30272 30275 +3
Branches 3078 3078
==========================================
- Hits 21364 19910 -1454
- Misses 8796 10183 +1387
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.67% <100.00%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.35% <100.00%> (+0.01%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [136 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [a52cfcd...9142502](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9673: [sql] optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-620786471
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a52cfcd234aa7d506c5d0ee659492e772940dbba&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
- Coverage 70.57% 70.35% -0.23%
==========================================
Files 581 581
Lines 30272 30275 +3
Branches 3078 3078
==========================================
- Hits 21364 21299 -65
- Misses 8796 8857 +61
- Partials 112 119 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.82% <ø> (-0.90%)` | :arrow_down: |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.67% <100.00%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.35% <100.00%> (+0.01%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `81.34% <0.00%> (-2.24%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [a52cfcd...9142502](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634358345
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634358345
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/65d185f15305a02b18f1a1cbcdb025e960d26492&el=desc) will **decrease** coverage by `5.32%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
- Coverage 70.79% 65.46% -5.33%
==========================================
Files 587 585 -2
Lines 30435 31048 +613
Branches 3152 3277 +125
==========================================
- Hits 21545 20327 -1218
- Misses 8776 10540 +1764
- Partials 114 181 +67
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.36% <ø> (+0.36%)` | :arrow_up: |
| #python | `69.77% <66.66%> (-1.19%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.28% <66.66%> (-0.09%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [290 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [65d185f...7ebf6e3](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634155128
While I don't doubt this does what the PR description says, it would be great if we could transfer some understanding that you've gathered during research for this PR into the code/docs. Reviewing this is quite difficult in part because of the following:
- Docstrings are very short or missing. Perhaps some examples could be added to the docstrings to explain what kind of tokens a typical SQL statement is decomposed into.
- Documentation for `sqlparse` is also quite incomprehensive.
- Variable names are not very descriptive. For example, `subtoken` might be more explanatory than `token2`.
This might be overkill, but it would be great if we could add a test that ensures that `self._extract_from_token` for a certain test case isn't called more than x times. That would make sure this parsing logic stays performant in the future, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-634358345
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/65d185f15305a02b18f1a1cbcdb025e960d26492&el=desc) will **decrease** coverage by `11.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
===========================================
- Coverage 70.79% 59.36% -11.43%
===========================================
Files 587 401 -186
Lines 30435 12840 -17595
Branches 3152 3277 +125
===========================================
- Hits 21545 7623 -13922
+ Misses 8776 5036 -3740
- Partials 114 181 +67
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.36% <ø> (+0.36%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [389 more](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [65d185f...e2e3c9b](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9673: [sql] optimize sql query parser
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673#issuecomment-620786471
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=h1) Report
> Merging [#9673](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a52cfcd234aa7d506c5d0ee659492e772940dbba&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9673 +/- ##
==========================================
- Coverage 70.57% 70.56% -0.01%
==========================================
Files 581 581
Lines 30272 30275 +3
Branches 3078 3078
==========================================
Hits 21364 21364
- Misses 8796 8799 +3
Partials 112 112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (-0.08%)` | :arrow_down: |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.67% <100.00%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.35% <100.00%> (+0.01%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/9673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=footer). Last update [a52cfcd...9142502](https://codecov.io/gh/apache/incubator-superset/pull/9673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9673: refactor(sql): optimize sql query parser
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9673:
URL: https://github.com/apache/incubator-superset/pull/9673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org