You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/12/07 15:54:15 UTC
[PR] Fix breeze check-release-files Command for Core+Task SDK checks [airflow]
jscheffl opened a new pull request, #59159:
URL: https://github.com/apache/airflow/pull/59159
While testing Airflow Core release checks for PMC for 3.1.4rc1 I found some small problems, this PR to fix:
- Description was missing that `--path-to-airflow-svn` is a required parameter
- breeze expected the parameter `--packages-file` which is only needed for providers as default was not given but need to exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix breeze check-release-files Command for Core+Task SDK checks [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59159:
URL: https://github.com/apache/airflow/pull/59159#issuecomment-3622710411
follow up here :) https://github.com/apache/airflow/pull/59164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix breeze check-release-files Command for Core+Task SDK checks [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #59159:
URL: https://github.com/apache/airflow/pull/59159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix breeze check-release-files Command for Core+Task SDK checks [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59159:
URL: https://github.com/apache/airflow/pull/59159#discussion_r2596478006
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -772,12 +772,12 @@ Optionally you can use the `breeze release-management check-release-files` comma
present in SVN. This command may also help with verifying installation of the packages.
```shell script
-breeze release-management check-release-files airflow --version ${VERSION_RC}
+breeze release-management check-release-files airflow --version ${VERSION_RC} --path-to-airflow-svn "${PATH_TO_AIRFLOW_SVN}"
```
```shell script
-breeze release-management check-release-files task-sdk --version ${TASK_SDK_VERSION_RC}
+breeze release-management check-release-files task-sdk --version ${TASK_SDK_VERSION_RC} --path-to-airflow-svn "${PATH_TO_AIRFLOW_SVN}/task-sdk"
Review Comment:
I have a different fix for that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix breeze check-release-files Command for Core+Task SDK checks [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #59159:
URL: https://github.com/apache/airflow/pull/59159#discussion_r2596479430
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -772,12 +772,12 @@ Optionally you can use the `breeze release-management check-release-files` comma
present in SVN. This command may also help with verifying installation of the packages.
```shell script
-breeze release-management check-release-files airflow --version ${VERSION_RC}
+breeze release-management check-release-files airflow --version ${VERSION_RC} --path-to-airflow-svn "${PATH_TO_AIRFLOW_SVN}"
```
```shell script
-breeze release-management check-release-files task-sdk --version ${TASK_SDK_VERSION_RC}
+breeze release-management check-release-files task-sdk --version ${TASK_SDK_VERSION_RC} --path-to-airflow-svn "${PATH_TO_AIRFLOW_SVN}/task-sdk"
Review Comment:
Oh, and which? :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix breeze check-release-files Command for Core+Task SDK checks [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59159:
URL: https://github.com/apache/airflow/pull/59159#issuecomment-3622684321
### Backport successfully created: v3-1-test
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/pull/59163"><img src="https://img.shields.io/badge/PR-59163-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org