You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Bruno Mahé (Created JIRA)" <ji...@apache.org> on 2011/12/30 21:16:30 UTC
[jira] [Created] (FLUME-914) Port the IRC sink to flume ng
Port the IRC sink to flume ng
-----------------------------
Key: FLUME-914
URL: https://issues.apache.org/jira/browse/FLUME-914
Project: Flume
Issue Type: New Feature
Components: Sinks+Sources
Reporter: Bruno Mahé
Assignee: Bruno Mahé
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-914) Port the IRC sink to flume ng
Posted by "Bruno Mahé (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Mahé updated FLUME-914:
-----------------------------
Status: Patch Available (was: Open)
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-914) Port the IRC sink to flume ng
Posted by "Bruno Mahé (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186110#comment-13186110 ]
Bruno Mahé commented on FLUME-914:
----------------------------------
Thanks a lot Prasad for the comments!
I believe this new patch on reviewboard addresses all your comments except 3). I couldn't find a nice way to go about it.
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-914) Port the IRC sink to flume ng
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189531#comment-13189531 ]
Hudson commented on FLUME-914:
------------------------------
Integrated in flume-728 #97 (See [https://builds.apache.org/job/flume-728/97/])
FLUME-914. Port the IRC sink to flume ng
(Bruno Mahé via Prasad Mujumdar)
prasadm : http://svn.apache.org/viewvc/?view=rev&rev=1233699
Files :
* /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java
* /incubator/flume/branches/flume-728/flume-ng-dist/pom.xml
* /incubator/flume/branches/flume-728/flume-ng-node/pom.xml
* /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/Application.java
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/pom.xml
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java
* /incubator/flume/branches/flume-728/flume-ng-sinks/pom.xml
* /incubator/flume/branches/flume-728/pom.xml
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Fix For: v1.1.0
>
> Attachments: FLUME-914-01-13.patch, FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-914) Port the IRC sink to flume ng
Posted by "Bruno Mahé (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Mahé updated FLUME-914:
-----------------------------
Attachment: FLUME-914-01-13.patch
Here is the updated patch
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914-01-13.patch, FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-914) Port the IRC sink to flume ng
Posted by "Bruno Mahé (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Mahé updated FLUME-914:
-----------------------------
Attachment: FLUME-914.patch
Here is a patch
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-914) Port the IRC sink to flume ng
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187206#comment-13187206 ]
jiraposter@reviews.apache.org commented on FLUME-914:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3502/#review4408
-----------------------------------------------------------
Ship it!
A few space nits, I will take care in the merge.
I guess with the latest codebase, you won't need to change the Application.java. Please rebase and regenerate the patch, I will go ahead and commit it.
- Prasad
On 2012-01-14 05:38:58, Bruno Mahé wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3502/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-14 05:38:58)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add a IRC sink to flume-ng
bq.
bq.
bq. This addresses bug FLUME-914.
bq. https://issues.apache.org/jira/browse/FLUME-914
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a
bq. flume-ng-dist/pom.xml 5c20252
bq. flume-ng-node/pom.xml c0e295c
bq. flume-ng-node/src/main/java/org/apache/flume/node/Application.java 07151d1
bq. flume-ng-sinks/flume-irc-sink/pom.xml PRE-CREATION
bq. flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java PRE-CREATION
bq. flume-ng-sinks/pom.xml 044bf8e
bq. pom.xml 6002358
bq.
bq. Diff: https://reviews.apache.org/r/3502/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * All unit tests pass
bq. * Started a Flume node with an irc sink and confirmed it worked
bq.
bq.
bq. Thanks,
bq.
bq. Bruno
bq.
bq.
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914-01-13.patch, FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-914) Port the IRC sink to flume ng
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186101#comment-13186101 ]
jiraposter@reviews.apache.org commented on FLUME-914:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3502/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Add a IRC sink to flume-ng
This addresses bug FLUME-914.
https://issues.apache.org/jira/browse/FLUME-914
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a
flume-ng-dist/pom.xml 5c20252
flume-ng-node/pom.xml c0e295c
flume-ng-node/src/main/java/org/apache/flume/node/Application.java 07151d1
flume-ng-sinks/flume-irc-sink/pom.xml PRE-CREATION
flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java PRE-CREATION
flume-ng-sinks/pom.xml 044bf8e
pom.xml 6002358
Diff: https://reviews.apache.org/r/3502/diff
Testing
-------
* All unit tests pass
* Started a Flume node with an irc sink and confirmed it worked
Thanks,
Bruno
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-914) Port the IRC sink to flume ng
Posted by "Prasad Mujumdar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186027#comment-13186027 ]
Prasad Mujumdar commented on FLUME-914:
---------------------------------------
+1
Changes look good !
Few minor comments -
1) Please rebase the changes. Flume-932 has changed the way you register sources/sinks. Now you don't need to register the sink in Application.java
2) IRCSink.java - Change tabs to space (ts=2)
3) I guess adding a unit test would be difficult, but please see if there's a way to add one.
4) We follow code review for any large patch, so please submit it via review board. I will approve it and commit it to ng branch.
thanks
Prasad
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-914) Port the IRC sink to flume ng
Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-914:
----------------------------------
Resolution: Fixed
Fix Version/s: v1.1.0
Status: Resolved (was: Patch Available)
Patch committed to NG branch.
Thanks Bruno !
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Fix For: v1.1.0
>
> Attachments: FLUME-914-01-13.patch, FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-914) Port the IRC sink to flume ng
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187214#comment-13187214 ]
jiraposter@reviews.apache.org commented on FLUME-914:
-----------------------------------------------------
bq. On 2012-01-16 21:31:54, Prasad Mujumdar wrote:
bq. > A few space nits, I will take care in the merge.
bq. > I guess with the latest codebase, you won't need to change the Application.java. Please rebase and regenerate the patch, I will go ahead and commit it.
bq. >
The change to Application.java only cleans up unnecessary imports. Do you want me to remove that change? it's not part of the ticket, but since it was done...
- Bruno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3502/#review4408
-----------------------------------------------------------
On 2012-01-14 05:38:58, Bruno Mahé wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3502/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-14 05:38:58)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add a IRC sink to flume-ng
bq.
bq.
bq. This addresses bug FLUME-914.
bq. https://issues.apache.org/jira/browse/FLUME-914
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a
bq. flume-ng-dist/pom.xml 5c20252
bq. flume-ng-node/pom.xml c0e295c
bq. flume-ng-node/src/main/java/org/apache/flume/node/Application.java 07151d1
bq. flume-ng-sinks/flume-irc-sink/pom.xml PRE-CREATION
bq. flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java PRE-CREATION
bq. flume-ng-sinks/pom.xml 044bf8e
bq. pom.xml 6002358
bq.
bq. Diff: https://reviews.apache.org/r/3502/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * All unit tests pass
bq. * Started a Flume node with an irc sink and confirmed it worked
bq.
bq.
bq. Thanks,
bq.
bq. Bruno
bq.
bq.
> Port the IRC sink to flume ng
> -----------------------------
>
> Key: FLUME-914
> URL: https://issues.apache.org/jira/browse/FLUME-914
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments: FLUME-914-01-13.patch, FLUME-914.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira