[GitHub] [pinot] KKcorps commented on a diff in pull request #9681: Close Filesystem on exit with Minion Tasks

[GitBox <gi...@apache.org>]

KKcorps commented on code in PR #9681:
URL: https://github.com/apache/pinot/pull/9681#discussion_r1012155629


##########
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFSFactory.java:
##########
@@ -74,9 +84,21 @@ public static void init(PinotConfiguration fsFactoryConfig) {
   }
 
   public static PinotFS create(String scheme) {

Review Comment:
   Yes, this is the reason I didn't rename.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org