You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ssisk <gi...@git.apache.org> on 2017/04/11 21:41:51 UTC
[GitHub] beam pull request #2499: HIFIO Cassandra tests were failing if run twice in ...
GitHub user ssisk opened a pull request:
https://github.com/apache/beam/pull/2499
HIFIO Cassandra tests were failing if run twice in a row without a clean
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
The embedded cassandra tests work correctly the first time they are run after a mvn clean - on any test phase execution of the jdk1.8-tests directory after that (ie, any time you run this unit tests again), they will fail. Thus, this passes our "mvn clean verify" runs and is not breaking CI, but will likely break any devs running tests in this directory locally without clean-ing. (aka, me)
R @dhalperi
R @tgroh
...whoever gets to this first
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ssisk/beam fix-cassandra-uts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2499
----
commit e72b13577d9d836aa7f0bc494725b1607aa8eb83
Author: Stephen Sisk <si...@google.com>
Date: 2017-04-11T21:36:05Z
HIFIO Cassandra tests were failing if run twice in a row without a clean
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2499: HIFIO Cassandra tests were failing if run twice in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---