You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/23 11:33:06 UTC

[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3454: Fix group ForceWrite not take effect with forceWriteMarkerSent in while loop of ForceWriteThread

StevenLuMT commented on code in PR #3454:
URL: https://github.com/apache/bookkeeper/pull/3454#discussion_r952493449


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -511,9 +511,9 @@ public void run() {
             boolean shouldForceWrite = true;
             int numReqInLastForceWrite = 0;
             long busyStartTime = System.nanoTime();
+            boolean forceWriteMarkerSent = false;

Review Comment:
   I think line:563 affects judgment @zymap 
   https://github.com/apache/bookkeeper/blob/149ecd93e75dd23447de9ea24bba68d7ef5a8e33/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java#L563



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org