You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by ge...@apache.org on 2004/01/19 17:15:13 UTC

cvs commit: modperl-2.0/t/response/TestAPI aplog.pm

geoff       2004/01/19 08:15:13

  Modified:    t/response/TestAPI aplog.pm
  Log:
  remove log_pid() call - it's meant for writing out the pid to a pidfile,
  truncating the existing file in the process.
  
  should this function be open at all?
  
  Revision  Changes    Path
  1.14      +4 -7      modperl-2.0/t/response/TestAPI/aplog.pm
  
  Index: aplog.pm
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/t/response/TestAPI/aplog.pm,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- aplog.pm	19 Jan 2004 15:54:58 -0000	1.13
  +++ aplog.pm	19 Jan 2004 16:15:13 -0000	1.14
  @@ -31,7 +31,7 @@
   
       $rlog->info($package, " test in progress");
   
  -    my($file, $line) = Apache::LOG_MARK;
  +    my($file, $line) = Apache::Log::LOG_MARK;
       ok $file eq __FILE__;
       ok $line == __LINE__ - 2;
   
  @@ -41,7 +41,7 @@
           ok sub { $slog->can($method) };
       }
   
  -    $s->log_serror(Apache::LOG_MARK, Apache::LOG_INFO|Apache::LOG_STARTUP,
  +    $s->log_serror(Apache::Log::LOG_MARK, Apache::LOG_INFO|Apache::LOG_STARTUP,
                      APR::SUCCESS, "This log message comes with no header");
   
       t_server_log_warn_is_expected();
  @@ -49,11 +49,11 @@
                      APR::SUCCESS, "log_serror test ok");
   
       t_server_log_warn_is_expected();
  -    $s->log_serror(Apache::LOG_MARK, Apache::LOG_DEBUG,
  +    $s->log_serror(Apache::Log::LOG_MARK, Apache::LOG_DEBUG,
                      APR::EGENERAL, "log_serror test 2 ok");
   
       t_server_log_error_is_expected();
  -    $r->log_rerror(Apache::LOG_MARK, Apache::LOG_CRIT,
  +    $r->log_rerror(Apache::Log::LOG_MARK, Apache::LOG_CRIT,
                      APR::ENOTIME, "log_rerror test ok");
   
       t_server_log_error_is_expected();
  @@ -67,9 +67,6 @@
       if ($s->error_fname) {
           #XXX: does not work under t/TEST -ssl
           $slog->debug(sub { die "set loglevel no workie" });
  -
  -        t_server_log_error_is_expected();
  -        Apache::Log::log_pid($r->pool, $s->error_fname);
       }
   
       $s->loglevel(Apache::LOG_DEBUG);