You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 23:27:38 UTC
[GitHub] [airflow] vikramkoka opened a new pull request #12974: Enhanced doc to cover ignoring rules and adding custom rules
vikramkoka opened a new pull request #12974:
URL: https://github.com/apache/airflow/pull/12974
Enhanced the upgrade-check documentation to cover how to ignore some of the
pre=defined checks as well as how to add custom checks.
This is in preparation for when the next release of the upgrade check scripts is cut.
@ashb @turbaszek @mik-laj @dimberman @kaxil
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12974: Enhanced doc to cover ignoring rules and adding custom rules
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12974:
URL: https://github.com/apache/airflow/pull/12974#discussion_r540203606
##########
File path: docs/apache-airflow/upgrade-check.rst
##########
@@ -163,3 +163,52 @@ statement for the Python Operator to be as follows will make this DAG work in Ai
However, at the time of writing, this is incompatible in Airflow 1.10.14. So, this change
can only be made while moving to Airflow 2.0.
+
+
+Turning off checks
+''''''''''''''''''
+
+Advanced Airflow users or those with multiple Airflow deployments may want to
+customize the Upgrade Checks to their environment by turning off certain
+checks which are not applicable to them. And example of this is users with
+Airflow deployments not using the KubePodOperator may want to turn off upgrade
+checks related to the KubePodOperator.
+
+This can be down by created an "upgrade config file" in yaml as shown below:
Review comment:
```suggestion
This can be done by creating an "upgrade config file" in YAML as shown below:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12974: Enhanced doc to cover ignoring rules and adding custom rules
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12974:
URL: https://github.com/apache/airflow/pull/12974#discussion_r540203365
##########
File path: docs/apache-airflow/upgrade-check.rst
##########
@@ -163,3 +163,52 @@ statement for the Python Operator to be as follows will make this DAG work in Ai
However, at the time of writing, this is incompatible in Airflow 1.10.14. So, this change
can only be made while moving to Airflow 2.0.
+
+
+Turning off checks
+''''''''''''''''''
+
+Advanced Airflow users or those with multiple Airflow deployments may want to
+customize the Upgrade Checks to their environment by turning off certain
+checks which are not applicable to them. And example of this is users with
+Airflow deployments not using the KubePodOperator may want to turn off upgrade
+checks related to the KubePodOperator.
Review comment:
```suggestion
Airflow deployments not using the ``KubernetesPodOperator`` may want to turn off upgrade
checks related to the ``KubernetesPodOperator``.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12974: Enhanced doc to cover ignoring rules and adding custom rules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12974:
URL: https://github.com/apache/airflow/pull/12974#issuecomment-742129992
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12974: Enhanced doc to cover ignoring rules and adding custom rules
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12974:
URL: https://github.com/apache/airflow/pull/12974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org