You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Wood, Aaron" <aa...@verizon.com> on 2016/10/10 18:39:52 UTC
Re: [E] Re: Require GCC >= 4.9
Hi,
-Wall and -Werror have been set on Mesos for quite some time now. It¹s
only in libprocess and stout that they were never set.
Good point about trusty not including gcc 4.9. Do you think it would be
acceptable to instruct people to take it from the toolchain PPA?
https://wiki.ubuntu.com/ToolChain#PPA_packages
Thanks,
Aaron
On 10/10/16, 2:18 PM, "Evers Benno" <be...@yandex-team.ru> wrote:
>Hi,
>I think this would break the build on ubuntu trusty, the latest natively
>available version there is 4.8.2
>
>Also, glancing at your review, I feel like `-Wall -Werror` is somewhat
>of an anti-pattern, it just seems to guarantee that the build will break
>whenever the compiler writers decide to add a new warning in the future,
>or when someone tries building with another compiler.
>
>Best regards,
>Benno
>
>On 10.10.2016 20:07, Wood, Aaron wrote:
>> Hi everyone,
>>
>> I am proposing that Mesos requires GCC >= 4.9 going forward instead of
>>>= 4.8.1. This is mainly to support -fstackprotector-strong.
>> See the related RR here https://reviews.apache.org/r/52645/
>>
>> How does everyone feel about this?
>>
>> Thanks,
>> Aaron
>>
Re: [E] Re: Require GCC >= 4.9
Posted by "Wood, Aaron" <aa...@verizon.com>.
Okay, I can add some logic to use the appropriate flag depending on the
compiler version. At least that way there is some sort of stack protection
for either case.
Thanks,
Aaron
On 10/11/16, 11:14 AM, "Joris Van Remoortere" <jo...@mesosphere.io> wrote:
>If the only win is the introduction of that flag I would tend to agree
>with
>Evers.
>
>The last time we bumped the compiler versions Cody did an analysis of all
>the major platforms and the ability to attain one of the required
>compilers
>easily.
>
>If we want to pursue bumping the minor versions for larger reasons (for
>example when we wanted c++11) we'll need to propose the change and provide
>some deprecation period regardless.
>
>―
>*Joris Van Remoortere*
>Mesosphere
>
>On Tue, Oct 11, 2016 at 4:53 AM, Evers Benno <be...@yandex-team.ru>
>wrote:
>
>> To be honest, I still think it's a pretty big pain to require a custom
>> compiler for mesos. From a packagers perspective, I would have to decide
>> if I should upload the PPA package to our repositories, backport gcc-4.9
>> myself, or just revert this patch in our build.
>>
>> It would also raise the barrier of entry for newcomers quite a bit,
>> right now the instructions at https://mesos.apache.org/gettingstarted/
>> are basically just "install this list of packages".
>>
>> Given that you probably have to add a check to configure.ac anyways to
>> warn people if their compiler doesn't support this option, would it be
>> an option to use -fstack-protector-strong on compilers that support it
>> and -fstack-protector otherwise?
>>
>> Best regards,
>> Benno
>>
>> On 10.10.2016 20:39, Wood, Aaron wrote:
>> > Hi,
>> >
>> > -Wall and -Werror have been set on Mesos for quite some time now. It¹s
>> > only in libprocess and stout that they were never set.
>> > Good point about trusty not including gcc 4.9. Do you think it would
>>be
>> > acceptable to instruct people to take it from the toolchain PPA?
>> > https://wiki.ubuntu.com/ToolChain#PPA_packages
>> >
>> > Thanks,
>> > Aaron
>> >
>> > On 10/10/16, 2:18 PM, "Evers Benno" <be...@yandex-team.ru> wrote:
>> >
>> >> Hi,
>> >> I think this would break the build on ubuntu trusty, the latest
>>natively
>> >> available version there is 4.8.2
>> >>
>> >> Also, glancing at your review, I feel like `-Wall -Werror` is
>>somewhat
>> >> of an anti-pattern, it just seems to guarantee that the build will
>>break
>> >> whenever the compiler writers decide to add a new warning in the
>>future,
>> >> or when someone tries building with another compiler.
>> >>
>> >> Best regards,
>> >> Benno
>> >>
>> >> On 10.10.2016 20:07, Wood, Aaron wrote:
>> >>> Hi everyone,
>> >>>
>> >>> I am proposing that Mesos requires GCC >= 4.9 going forward instead
>>of
>> >>>> = 4.8.1. This is mainly to support -fstackprotector-strong.
>> >>> See the related RR here https://reviews.apache.org/r/52645/
>> >>>
>> >>> How does everyone feel about this?
>> >>>
>> >>> Thanks,
>> >>> Aaron
>> >>>
>> >
>>
Re: [E] Re: Require GCC >= 4.9
Posted by Joris Van Remoortere <jo...@mesosphere.io>.
If the only win is the introduction of that flag I would tend to agree with
Evers.
The last time we bumped the compiler versions Cody did an analysis of all
the major platforms and the ability to attain one of the required compilers
easily.
If we want to pursue bumping the minor versions for larger reasons (for
example when we wanted c++11) we'll need to propose the change and provide
some deprecation period regardless.
—
*Joris Van Remoortere*
Mesosphere
On Tue, Oct 11, 2016 at 4:53 AM, Evers Benno <be...@yandex-team.ru> wrote:
> To be honest, I still think it's a pretty big pain to require a custom
> compiler for mesos. From a packagers perspective, I would have to decide
> if I should upload the PPA package to our repositories, backport gcc-4.9
> myself, or just revert this patch in our build.
>
> It would also raise the barrier of entry for newcomers quite a bit,
> right now the instructions at https://mesos.apache.org/gettingstarted/
> are basically just "install this list of packages".
>
> Given that you probably have to add a check to configure.ac anyways to
> warn people if their compiler doesn't support this option, would it be
> an option to use -fstack-protector-strong on compilers that support it
> and -fstack-protector otherwise?
>
> Best regards,
> Benno
>
> On 10.10.2016 20:39, Wood, Aaron wrote:
> > Hi,
> >
> > -Wall and -Werror have been set on Mesos for quite some time now. It¹s
> > only in libprocess and stout that they were never set.
> > Good point about trusty not including gcc 4.9. Do you think it would be
> > acceptable to instruct people to take it from the toolchain PPA?
> > https://wiki.ubuntu.com/ToolChain#PPA_packages
> >
> > Thanks,
> > Aaron
> >
> > On 10/10/16, 2:18 PM, "Evers Benno" <be...@yandex-team.ru> wrote:
> >
> >> Hi,
> >> I think this would break the build on ubuntu trusty, the latest natively
> >> available version there is 4.8.2
> >>
> >> Also, glancing at your review, I feel like `-Wall -Werror` is somewhat
> >> of an anti-pattern, it just seems to guarantee that the build will break
> >> whenever the compiler writers decide to add a new warning in the future,
> >> or when someone tries building with another compiler.
> >>
> >> Best regards,
> >> Benno
> >>
> >> On 10.10.2016 20:07, Wood, Aaron wrote:
> >>> Hi everyone,
> >>>
> >>> I am proposing that Mesos requires GCC >= 4.9 going forward instead of
> >>>> = 4.8.1. This is mainly to support -fstackprotector-strong.
> >>> See the related RR here https://reviews.apache.org/r/52645/
> >>>
> >>> How does everyone feel about this?
> >>>
> >>> Thanks,
> >>> Aaron
> >>>
> >
>
Re: [E] Re: Require GCC >= 4.9
Posted by Evers Benno <be...@yandex-team.ru>.
To be honest, I still think it's a pretty big pain to require a custom
compiler for mesos. From a packagers perspective, I would have to decide
if I should upload the PPA package to our repositories, backport gcc-4.9
myself, or just revert this patch in our build.
It would also raise the barrier of entry for newcomers quite a bit,
right now the instructions at https://mesos.apache.org/gettingstarted/
are basically just "install this list of packages".
Given that you probably have to add a check to configure.ac anyways to
warn people if their compiler doesn't support this option, would it be
an option to use -fstack-protector-strong on compilers that support it
and -fstack-protector otherwise?
Best regards,
Benno
On 10.10.2016 20:39, Wood, Aaron wrote:
> Hi,
>
> -Wall and -Werror have been set on Mesos for quite some time now. Its
> only in libprocess and stout that they were never set.
> Good point about trusty not including gcc 4.9. Do you think it would be
> acceptable to instruct people to take it from the toolchain PPA?
> https://wiki.ubuntu.com/ToolChain#PPA_packages
>
> Thanks,
> Aaron
>
> On 10/10/16, 2:18 PM, "Evers Benno" <be...@yandex-team.ru> wrote:
>
>> Hi,
>> I think this would break the build on ubuntu trusty, the latest natively
>> available version there is 4.8.2
>>
>> Also, glancing at your review, I feel like `-Wall -Werror` is somewhat
>> of an anti-pattern, it just seems to guarantee that the build will break
>> whenever the compiler writers decide to add a new warning in the future,
>> or when someone tries building with another compiler.
>>
>> Best regards,
>> Benno
>>
>> On 10.10.2016 20:07, Wood, Aaron wrote:
>>> Hi everyone,
>>>
>>> I am proposing that Mesos requires GCC >= 4.9 going forward instead of
>>>> = 4.8.1. This is mainly to support -fstackprotector-strong.
>>> See the related RR here https://reviews.apache.org/r/52645/
>>>
>>> How does everyone feel about this?
>>>
>>> Thanks,
>>> Aaron
>>>
>