You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "sunank200 (via GitHub)" <gi...@apache.org> on 2023/02/14 17:28:36 UTC

[GitHub] [airflow] sunank200 commented on pull request #29038: Add HttpHookAsync for deferrable implementation

sunank200 commented on PR #29038:
URL: https://github.com/apache/airflow/pull/29038#issuecomment-1430117087

   > it looks like test_do_api_call_async_retryable_error at tests/providers/http/hooks/test_http.py:436 was committed with a failing test. It seems to me that the underlying aioreponses request_mock call is raising a ClientConnectionError, which isn't caught in [HttpAsyncHook](https://github.com/apache/airflow/blob/28126c12fbdd2cac84e0fbcf2212154085aa5ed9/airflow/providers/http/hooks/http.py#L374)
   
   @syun64 I think the test missed the pytest fixture aioresponse. Added it in this PR: https://github.com/apache/airflow/pull/29540


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org