You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/07/04 02:08:13 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41842: [MINOR] Eliminate maven build warnings: Using platform locale (en actually) to format date/time, i.e. build is platform dependent!
panbingkun opened a new pull request, #41842:
URL: https://github.com/apache/spark/pull/41842
### What changes were proposed in this pull request?
The pr aims to eliminate maven build warnings: `Using platform locale (en actually) to format date/time, i.e. build is platform dependent!`
### Why are the changes needed?
Eliminate maven build warnings.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Pass GA.
- Manually test:
Before:
'''
[INFO] --- build-helper-maven-plugin:3.4.0:timestamp-property (module-timestamp-property) @ spark-catalyst_2.12 ---
[WARNING] Using platform locale (en_CN actually) to format date/time, i.e. build is platform dependent!
[INFO]
[INFO] --- build-helper-maven-plugin:3.4.0:timestamp-property (local-timestamp-property) @ spark-catalyst_2.12 ---
[WARNING] Using platform locale (en_CN actually) to format date/time, i.e. build is platform dependent!
'''
After:
The above warning has been eliminated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41842: [MINOR] Eliminate maven build warnings: Using platform locale (en actually) to format date/time, i.e. build is platform dependent!
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41842:
URL: https://github.com/apache/spark/pull/41842#issuecomment-1619364071
Before:
<img width="773" alt="image" src="https://github.com/apache/spark/assets/15246973/0597af6d-734a-4e39-a46a-80bc6032afee">
After:
<img width="783" alt="image" src="https://github.com/apache/spark/assets/15246973/abd6ebcb-a87a-489f-bd39-0aa9477f9f3d">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41842: [MINOR] Eliminate maven build warnings: Using platform locale (en actually) to format date/time, i.e. build is platform dependent!
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41842:
URL: https://github.com/apache/spark/pull/41842#issuecomment-1620956381
cc @HyukjinKwon @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR] Eliminate maven build warnings: Using platform locale (en actually) to format date/time, i.e. build is platform dependent! [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #41842: [MINOR] Eliminate maven build warnings: Using platform locale (en actually) to format date/time, i.e. build is platform dependent!
URL: https://github.com/apache/spark/pull/41842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41842: [MINOR] Eliminate maven build warnings: Using platform locale (en actually) to format date/time, i.e. build is platform dependent!
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41842:
URL: https://github.com/apache/spark/pull/41842#discussion_r1251409445
##########
pom.xml:
##########
@@ -2836,6 +2836,7 @@
<pattern>${maven.build.timestamp.format}</pattern>
<timeSource>current</timeSource>
<timeZone>America/Los_Angeles</timeZone>
+ <locale>en,US</locale>
Review Comment:
<img width="780" alt="image" src="https://github.com/apache/spark/assets/15246973/afc02a13-d494-4503-98df-a779d923fd45">
Because the default attribute of github is also this, setting this value is reasonable.
https://github.com/LuciferYang/spark/actions/runs/5274544416/jobs/9541917589#logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR] Eliminate maven build warnings: Using platform locale (en actually) to format date/time, i.e. build is platform dependent! [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41842:
URL: https://github.com/apache/spark/pull/41842#issuecomment-1762416203
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org