[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #17740: Refactor helm to use the new values.yaml structure

[GitBox <gi...@apache.org>]

TeslaCN commented on code in PR #17740:
URL: https://github.com/apache/shardingsphere/pull/17740#discussion_r874665176


##########
shardingsphere-charts/shardingsphere-proxy/values.yaml:
##########
@@ -15,66 +15,127 @@
 #  limitations under the License.
 #
 
-## @section Global Configuration
-## Global Configuration
-## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
-## @param global.resources.limits The resources limits for all containers
-## @param global.resources.requests The requested resources for all containers
-global:
-  resources:
-    limits: {}
-    requests: {}
-
-## @section MySQL Configuration
-## MySQL Configuration
-## ref:https://kubernetes.io/docs/concepts/storage/storage-classes/
-## @param mysql.enabled Enable MySQL sub-charts dependency
-## @param mysql.storageclass Storage class needed by MySQL persistent storage
-## @param mysql.storagerequest Space for MySQL persistent storage
-mysql:
-  enabled: true
-  storageclass:
-  storagerequest:
-
-## @section ZooKeeper Configuration
-## ZooKeeper Configuration
-## ref:https://kubernetes.io/docs/concepts/storage/storage-classes/
-## @param zookeeper.enabled Enable ZooKeeper sub-charts dependency
-## @param zookeeper.storageclass Storage class needed by ZooKeeper persistent storage
-## @param zookeeper.storagerequest Space for ZooKeeper persistent storage
-zookeeper:
+## @section Governance-Node parameters
+## @param governance.enabled Switch to enable or disable the governance helm chart
+##
+governance:
   enabled: true
-  storageclass:
-  storagerequest:
+  ## @section Governance-Node ZooKeeper parameters
+  zookeeper:
+    ## @param governance.zookeeper.enabled Switch to enable or disable the ZooKeeper helm chart
+    ##
+    enabled: true
+    ## @param governance.zookeeper.replicaCount Number of ZooKeeper nodes
+    ##
+    replicaCount: 1
+    ## ZooKeeper Persistence parameters
+    ## ref: https://kubernetes.io/docs/user-guide/persistent-volumes/
+    ## @param governance.zookeeper.persistence.enabled Enable persistence on ZooKeeper using PVC(s)
+    ## @param governance.zookeeper.persistence.storageClass Persistent Volume storage class
+    ## @param governance.zookeeper.persistence.accessModes Persistent Volume access modes
+    ## @param governance.zookeeper.persistence.size Persistent Volume size
+    ##
+    persistence:
+      enabled: false
+      storageClass: ""
+      accessModes:
+        - ReadWriteOnce
+      size: 8Gi
+    ## ZooKeeper's resource requests and limits
+    ## ref: https://kubernetes.io/docs/user-guide/compute-resources/
+    ## @param governance.zookeeper.resources.limits The resources limits for the ZooKeeper containers
+    ## @param governance.zookeeper.resources.requests.memory The requested memory for the ZooKeeper containers
+    ## @param governance.zookeeper.resources.requests.cpu The requested cpu for the ZooKeeper containers
+    ##
+    resources:
+      limits: {}
+      requests:
+        memory: 256Mi
+        cpu: 250m
 
-## @section ShardingSphere-Proxy Configuration
-## Image Parameters
-## ref: https://kubernetes.io/docs/concepts/containers/images/
-## @param image.repository Image name of ShardingSphere-Proxy. Pull from apache official repository by default
-## @param image.pullPolicy The policy for pulling an image
-## @param image.tag Image tag
-image:
-  repository: apache/shardingsphere-proxy
-  pullPolicy: IfNotPresent
-  # Overrides the image tag whose default is the chart appVersion.
-  tag: "5.1.1"
+## @section Compute-Node parameters
+## 
+compute:
+  ## @section Compute-Node ShardingSphere-Proxy  parameters
+  ## ref: https://kubernetes.io/docs/concepts/containers/images/
+  ## @param compute.image.repository Image name of ShardingSphere-Proxy.
+  ## @param compute.image.pullPolicy The policy for pulling ShardingSphere-Proxy image
+  ## @param compute.image.tag ShardingSphere-Proxy image tag
+  ##
+  image:
+    repository: "apache/shardingsphere-proxy"
+    pullPolicy: IfNotPresent
+    ## Overrides the image tag whose default is the chart appVersion.
+    ##
+    tag: "5.1.2"
+  ## @param compute.imagePullSecrets Specify docker-registry secret names as an array
+  ## e.g：
+  ## imagePullSecrets:
+  ##   - name: myRegistryKeySecretName
+  ##
+  imagePullSecrets: []
+  ## ShardingSphere-Proxy resource requests and limits
+  ## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
+  ## @param compute.resources.limits The resources limits for the ShardingSphere-Proxy containers
+  ## @param compute.resources.requests.memory The requested memory for the ShardingSphere-Proxy containers
+  ## @param compute.resources.requests.cpu The requested cpu for the ShardingSphere-Proxy containers
+  ##
+  resources:
+    limits: {}
+    requests:
+      memory: 1.6Gi

Review Comment:
   Proxy requests at least 2.5G by default.
   
   https://github.com/apache/shardingsphere/blob/master/shardingsphere-distribution/shardingsphere-proxy-distribution/src/main/resources/bin/start.sh#L60



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org