[GitHub] sijie commented on a change in pull request #788: Issue 787: Client should be able to get ledger metadata from Handles.

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #788: Issue 787: Client should be able to get ledger metadata from Handles.
URL: https://github.com/apache/bookkeeper/pull/788#discussion_r153757016
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerMetadata.java
 ##########
 @@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.bookkeeper.client.api;
+
+import java.io.Serializable;
+import java.util.List;
+import java.util.Map;
+import java.util.NavigableMap;
+import org.apache.bookkeeper.common.annotation.InterfaceAudience.LimitedPrivate;
+import org.apache.bookkeeper.common.annotation.InterfaceStability.Unstable;
+import org.apache.bookkeeper.net.BookieSocketAddress;
+
+/**
+ * Represents the client-side metadata of a ledger. It is immutable.
+ *
+ * @since 4.6
+ */
+@LimitedPrivate
+@Unstable
+public interface LedgerMetadata extends Serializable {
+
+    /**
+     * Returns the ensemble size of this ledger.
+     *
+     * @return the ensemble size of this ledger.
+     */
+    int getEnsembleSize();
+
+    /**
+     * Returns the write quorum size of this ledger.
+     *
+     * @return the write quorum size of this ledger.
+     */
+    int getWriteQuorumSize();
+
+    /**
+     * Returns the ack quorum size of this ledger.
+     *
+     * @return the ack quorum size of this ledger.
+     */
+    int getAckQuorumSize();
+
+    /**
+     * Returns the last entry id of this ledger.
+     *
+     * <p>If this ledger is not sealed {@link #isSealed()}, it returns {@code -1L}.
+     *
+     * @return the last entry id of this ledger if it is sealed, otherwise -1.
+     */
+    long getLastEntryId();
+
+    /**
+     * Returns the length of this ledger.
+     *
+     * <p>If this ledger is not sealed {@link #isSealed()}, it returns {@code 0}.
+     *
+     * @return the length of this ledger if it is sealed, otherwise 0.
+     */
+    long getLength();
 
 Review comment:
   I am not sure this should be Optional. there is no point for Optional. If no data is written to a ledger, the length is 0 and last entry id is -1L. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services