[GitHub] [kvrocks] tisonkun added a comment to the discussion: How to maintain the squash commit message

["tisonkun (via GitHub)" <gi...@apache.org>]

GitHub user tisonkun added a comment to the discussion: How to maintain the squash commit message

My practice in our project is -

1. Retain sign-off and co-author-by footers.
2. Drop meaningless (intermediate) commit messages when the author didn't prepare it.
3. Retain commit messages when the author carefully write it.

It's easy for me to follow. Any "principle" or "best practice" proposal can work to a better situation, but it shouldn't be a blocker to contributors - I'm fine with contributions without better written commit message, as long as the PR description is clear or the change is itself straightforward.

GitHub link: https://github.com/apache/kvrocks/discussions/1553#discussioncomment-6370901

----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org