You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/13 07:54:22 UTC

Review Request 35414: DRILL-3285: Part 2--Renaming.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35414/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-3285
    https://issues.apache.org/jira/browse/DRILL-3285


Repository: drill-git


Description
-------

Renamed state/control-flow members:
- started -> initialSchemaLoaded
- first -> beforeFirstBatch
- redoFirstNext -> returnTrueForNextCallToNext
- finished -> afterLastRow

Renamed other items:
- changed -> schemaChanged
- currentBatch -> currentBatchHolder
 - DrillResultSet's currentBatch -> batchLoader


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d 

Diff: https://reviews.apache.org/r/35414/diff/


Testing
-------

Ran tests (all parts together); no new errors.


Thanks,

Daniel Barclay