DO NOT REPLY [Bug 13563] New: - StringTagSupport is broken for tag handler reuse

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13563>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13563

StringTagSupport is broken for tag handler reuse

           Summary: StringTagSupport is broken for tag handler reuse
           Product: Taglibs
           Version: 1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Other
         Component: String Taglib
        AssignedTo: taglibs-dev@jakarta.apache.org
        ReportedBy: martinc@apache.org


The tags in the String taglib which extend StringTagSupport are broken for 
containers which reuse tag handler instances. The problem is in 
StringTagSupport.java, where initAttributes() is being called from within 
doEndTag(). Since the container is not required to reinitialise the attributes 
for a tag handler instance if they have the same values - which they might do 
in a loop, for example - the tag produces incorrect results after the first 
call.

The fix is simply to remove the call to initAttributes() from doEndTag().

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>