[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4415: Align the server/engine ExecuteStatement operation handle for Spark engine

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4415:
URL: https://github.com/apache/kyuubi/pull/4415#discussion_r1118045639


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/SparkOperation.scala:
##########
@@ -123,7 +123,7 @@ abstract class SparkOperation(session: Session)
 
   protected def eventEnabled: Boolean = true
 
-  if (eventEnabled) EventBus.post(SparkOperationEvent(this))
+  if (handle != null && eventEnabled) EventBus.post(SparkOperationEvent(this))

Review Comment:
   in which case that `handle == null` is true?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org