You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2023/01/28 20:33:32 UTC

[maven-reporting-impl] branch master updated: Add TODOs

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-reporting-impl.git


The following commit(s) were added to refs/heads/master by this push:
     new 936a3e4  Add TODOs
936a3e4 is described below

commit 936a3e42cf42f9ce75ee3181b9b4b65682b6192c
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat Jan 28 21:25:36 2023 +0100

    Add TODOs
---
 .../java/org/apache/maven/reporting/AbstractMavenReportRenderer.java  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java b/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
index 3ff849d..7527ec7 100644
--- a/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
+++ b/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
@@ -154,6 +154,7 @@ public abstract class AbstractMavenReportRenderer
      */
     protected void startTable()
     {
+        // TODO pass null, since left is implied
         startTable( new int[] {Sink.JUSTIFY_LEFT}, false );
     }
 
@@ -374,6 +375,7 @@ public abstract class AbstractMavenReportRenderer
      */
     protected void verbatimText( String text )
     {
+        // FIXME drop BOXED
         sink.verbatim( SinkEventAttributeSet.BOXED );
 
         text( text );
@@ -399,6 +401,7 @@ public abstract class AbstractMavenReportRenderer
         }
         else
         {
+            // FIXME drop BOXED
             sink.verbatim( SinkEventAttributeSet.BOXED );
 
             link( href, text );
@@ -415,6 +418,7 @@ public abstract class AbstractMavenReportRenderer
      */
     protected void javaScript( String jsCode )
     {
+        // TODO drop type, it is implied in HTML5
         sink.rawText( "<script type=\"text/javascript\">\n" + jsCode + "</script>" );
     }