You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org> on 2007/11/09 03:18:50 UTC

[jira] Created: (TRINIDAD-810) Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element

Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
-----------------------------------------------------------------------------------------------------------------------

                 Key: TRINIDAD-810
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-810
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Plugins
    Affects Versions:  1.2.3-plugins
            Reporter: Andrew Robinson
            Assignee: Andrew Robinson


Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element

example XML source:

    <property>
      <description><![CDATA[test]]></description>
      <property-name>myProperty</property-name>
      <property-class>java.lang.String</property-class>
      <default-value>one</default-value>
      <property-extension>
        <mfp:required>false</mfp:required>
        <mfp:property-values>one two three four</mfp:property-values>
        <mfp:property-metadata>
          <mfp:preferred>true</mfp:preferred>
        </mfp:property-metadata>
      </property-extension>
    </property>

Currently generates:

      <property>
         <description>test</description>
         <property-name>myProperty</property-name>
         <property-class>java.lang.String</property-class>
         <default-value>one</default-value>
         <property-extension>
            <attribute-values>one two three four</attribute-values>
            <property-metadata>
               <preferred>true</preferred>
            </property-metadata>
         </property-extension>
      </property>

Desired result:

      <property>
         <description>test</description>
         <property-name>myProperty</property-name>
         <property-class>java.lang.String</property-class>
         <default-value>one</default-value>
         <property-extension>
            <property-metadata>
               <preferred>true</preferred>
               <attribute-values>one two three four</attribute-values>
            </property-metadata>
         </property-extension>
      </property>

notice the new location of "<attribute-values>"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (TRINIDAD-810) Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element

Posted by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Robinson resolved TRINIDAD-810.
--------------------------------------

    Resolution: Fixed

Change the output location of the attribute-values element when there is a property-metadata element present in the source file

Did this by ignoring the element in the parent node and pulling in the property-values element from inside the property-metadata match

> Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-810
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-810
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions:  1.2.3-plugins
>            Reporter: Andrew Robinson
>            Assignee: Andrew Robinson
>
> Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
> example XML source:
>     <property>
>       <description><![CDATA[test]]></description>
>       <property-name>myProperty</property-name>
>       <property-class>java.lang.String</property-class>
>       <default-value>one</default-value>
>       <property-extension>
>         <mfp:required>false</mfp:required>
>         <mfp:property-values>one two three four</mfp:property-values>
>         <mfp:property-metadata>
>           <mfp:preferred>true</mfp:preferred>
>         </mfp:property-metadata>
>       </property-extension>
>     </property>
> Currently generates:
>       <property>
>          <description>test</description>
>          <property-name>myProperty</property-name>
>          <property-class>java.lang.String</property-class>
>          <default-value>one</default-value>
>          <property-extension>
>             <attribute-values>one two three four</attribute-values>
>             <property-metadata>
>                <preferred>true</preferred>
>             </property-metadata>
>          </property-extension>
>       </property>
> Desired result:
>       <property>
>          <description>test</description>
>          <property-name>myProperty</property-name>
>          <property-class>java.lang.String</property-class>
>          <default-value>one</default-value>
>          <property-extension>
>             <property-metadata>
>                <preferred>true</preferred>
>                <attribute-values>one two three four</attribute-values>
>             </property-metadata>
>          </property-extension>
>       </property>
> notice the new location of "<attribute-values>"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (TRINIDAD-810) Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element

Posted by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541206 ] 

Andrew Robinson commented on TRINIDAD-810:
------------------------------------------

The reason that the attribute needs to be located directly under the "<property-extension>", is that the Mojo class needs access to it

> Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-810
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-810
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions:  1.2.3-plugins
>            Reporter: Andrew Robinson
>            Assignee: Andrew Robinson
>
> Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
> example XML source:
>     <property>
>       <description><![CDATA[test]]></description>
>       <property-name>myProperty</property-name>
>       <property-class>java.lang.String</property-class>
>       <default-value>one</default-value>
>       <property-extension>
>         <mfp:required>false</mfp:required>
>         <mfp:property-values>one two three four</mfp:property-values>
>         <mfp:property-metadata>
>           <mfp:preferred>true</mfp:preferred>
>         </mfp:property-metadata>
>       </property-extension>
>     </property>
> Currently generates:
>       <property>
>          <description>test</description>
>          <property-name>myProperty</property-name>
>          <property-class>java.lang.String</property-class>
>          <default-value>one</default-value>
>          <property-extension>
>             <attribute-values>one two three four</attribute-values>
>             <property-metadata>
>                <preferred>true</preferred>
>             </property-metadata>
>          </property-extension>
>       </property>
> Desired result:
>       <property>
>          <description>test</description>
>          <property-name>myProperty</property-name>
>          <property-class>java.lang.String</property-class>
>          <default-value>one</default-value>
>          <property-extension>
>             <property-metadata>
>                <preferred>true</preferred>
>                <attribute-values>one two three four</attribute-values>
>             </property-metadata>
>          </property-extension>
>       </property>
> notice the new location of "<attribute-values>"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Reopened: (TRINIDAD-810) Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element

Posted by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Robinson reopened TRINIDAD-810:
--------------------------------------


re-opening to add the fix version

> Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-810
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-810
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions:  1.2.3-plugins
>            Reporter: Andrew Robinson
>            Assignee: Andrew Robinson
>
> Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
> example XML source:
>     <property>
>       <description><![CDATA[test]]></description>
>       <property-name>myProperty</property-name>
>       <property-class>java.lang.String</property-class>
>       <default-value>one</default-value>
>       <property-extension>
>         <mfp:required>false</mfp:required>
>         <mfp:property-values>one two three four</mfp:property-values>
>         <mfp:property-metadata>
>           <mfp:preferred>true</mfp:preferred>
>         </mfp:property-metadata>
>       </property-extension>
>     </property>
> Currently generates:
>       <property>
>          <description>test</description>
>          <property-name>myProperty</property-name>
>          <property-class>java.lang.String</property-class>
>          <default-value>one</default-value>
>          <property-extension>
>             <attribute-values>one two three four</attribute-values>
>             <property-metadata>
>                <preferred>true</preferred>
>             </property-metadata>
>          </property-extension>
>       </property>
> Desired result:
>       <property>
>          <description>test</description>
>          <property-name>myProperty</property-name>
>          <property-class>java.lang.String</property-class>
>          <default-value>one</default-value>
>          <property-extension>
>             <property-metadata>
>                <preferred>true</preferred>
>                <attribute-values>one two three four</attribute-values>
>             </property-metadata>
>          </property-extension>
>       </property>
> notice the new location of "<attribute-values>"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (TRINIDAD-810) Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element

Posted by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Robinson resolved TRINIDAD-810.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.4-plugins

Adding the fix version

> Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-810
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-810
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions:  1.2.3-plugins
>            Reporter: Andrew Robinson
>            Assignee: Andrew Robinson
>             Fix For: 1.2.4-plugins
>
>
> Faces plugin copies the property-values to attribute-values incorrectly if there is a sibling property-metadata element
> example XML source:
>     <property>
>       <description><![CDATA[test]]></description>
>       <property-name>myProperty</property-name>
>       <property-class>java.lang.String</property-class>
>       <default-value>one</default-value>
>       <property-extension>
>         <mfp:required>false</mfp:required>
>         <mfp:property-values>one two three four</mfp:property-values>
>         <mfp:property-metadata>
>           <mfp:preferred>true</mfp:preferred>
>         </mfp:property-metadata>
>       </property-extension>
>     </property>
> Currently generates:
>       <property>
>          <description>test</description>
>          <property-name>myProperty</property-name>
>          <property-class>java.lang.String</property-class>
>          <default-value>one</default-value>
>          <property-extension>
>             <attribute-values>one two three four</attribute-values>
>             <property-metadata>
>                <preferred>true</preferred>
>             </property-metadata>
>          </property-extension>
>       </property>
> Desired result:
>       <property>
>          <description>test</description>
>          <property-name>myProperty</property-name>
>          <property-class>java.lang.String</property-class>
>          <default-value>one</default-value>
>          <property-extension>
>             <property-metadata>
>                <preferred>true</preferred>
>                <attribute-values>one two three four</attribute-values>
>             </property-metadata>
>          </property-extension>
>       </property>
> notice the new location of "<attribute-values>"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.