[GitHub] [iceberg] rdblue commented on a change in pull request #3430: Spark: Remove reflection workarounds from v3.0 and v3.1 code

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3430:
URL: https://github.com/apache/iceberg/pull/3430#discussion_r740337346



##########
File path: spark/v3.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/AssignmentAlignmentSupport.scala
##########
@@ -100,7 +99,7 @@ trait AssignmentAlignmentSupport {
             case StructType(fields) =>
               // build field expressions
               val fieldExprs = fields.zipWithIndex.map { case (field, ordinal) =>
-                createAlias(GetStructField(col, ordinal, Some(field.name)), field.name)
+                Alias(GetStructField(col, ordinal, Some(field.name)), field.name)()

Review comment:
       I think that we should leave the reflection in 3.0. We aren't renaming the `iceberg-spark3-runtime` Jar so it is possible that people currently using it for 3.1 will continue to. As long as we can maintain compatibility with that by doing nothing, I think we should. I don't think that it is necessary to do much else, but I don't see a reason to remove the compatibility.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org