You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/13 23:28:49 UTC
[GitHub] [helix] jiajunwang opened a new pull request #1465: Adding release notes for 0.9.8 (hotfix).
jiajunwang opened a new pull request #1465:
URL: https://github.com/apache/helix/pull/1465
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
NA, doc change only
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
This PR adds 0.9.8 release notes and other documents.
Release 0.9.8 is a hotfix version based on 0.9.7.
Note that we are not adding 0.9.8 into the main page before vote completes. There might be some updates later based on the discussions.
Please refer to the following snapshot for the release detail.
### Tests
- [X] The following tests are written for this issue:
NA
- [X] The following is the result of the "mvn test" command on the appropriate module:
mvn site:site
mvn site:stage
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1465: Adding release notes for 0.9.8 (hotfix).
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1465:
URL: https://github.com/apache/helix/pull/1465#discussion_r504890469
##########
File path: website/0.9.8/src/site/apt/releasenotes/release-0.9.8.apt
##########
@@ -0,0 +1,59 @@
+ -----
+ Release Notes for Apache Helix 0.9.8
+ -----
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/guides/mini/guide-apt-format.html
+
+Release Notes for Apache Helix 0.9.8
+
+ The Apache Helix team would like to announce the release of Apache Helix 0.9.8.
+
+ This is the twenty-third release under the Apache umbrella, and the sixteenth as a top-level project.
+
+ Helix is a generic cluster management framework used for the automatic management of partitioned, replicated and distributed resources hosted on a cluster of nodes.
+
+ In this release, Helix provides several interface improvements and bug fixes:
+
+[]
+
+* Key Note for Helix Release
+
+** Critical Bug Fixes and Craftsmanship Improvements
+
+ In this release, we fixed one critical bugs in Helix ZkClient. There are also several fixes for craftsmanship and interfaces improvements.
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1465: Adding release notes for 0.9.8 (hotfix).
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1465:
URL: https://github.com/apache/helix/pull/1465#discussion_r504891021
##########
File path: website/0.9.8/src/site/apt/releasenotes/release-0.9.8.apt
##########
@@ -0,0 +1,59 @@
+ -----
+ Release Notes for Apache Helix 0.9.8
+ -----
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/guides/mini/guide-apt-format.html
+
+Release Notes for Apache Helix 0.9.8
+
+ The Apache Helix team would like to announce the release of Apache Helix 0.9.8.
+
+ This is the twenty-third release under the Apache umbrella, and the sixteenth as a top-level project.
Review comment:
That's the convention...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on a change in pull request #1465: Adding release notes for 0.9.8 (hotfix).
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on a change in pull request #1465:
URL: https://github.com/apache/helix/pull/1465#discussion_r504878668
##########
File path: website/0.9.8/src/site/apt/releasenotes/release-0.9.8.apt
##########
@@ -0,0 +1,59 @@
+ -----
+ Release Notes for Apache Helix 0.9.8
+ -----
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/guides/mini/guide-apt-format.html
+
+Release Notes for Apache Helix 0.9.8
+
+ The Apache Helix team would like to announce the release of Apache Helix 0.9.8.
+
+ This is the twenty-third release under the Apache umbrella, and the sixteenth as a top-level project.
+
+ Helix is a generic cluster management framework used for the automatic management of partitioned, replicated and distributed resources hosted on a cluster of nodes.
+
+ In this release, Helix provides several interface improvements and bug fixes:
+
+[]
+
+* Key Note for Helix Release
+
+** Critical Bug Fixes and Craftsmanship Improvements
+
+ In this release, we fixed one critical bugs in Helix ZkClient. There are also several fixes for craftsmanship and interfaces improvements.
Review comment:
*bug
##########
File path: website/0.9.8/src/site/apt/releasenotes/release-0.9.8.apt
##########
@@ -0,0 +1,59 @@
+ -----
+ Release Notes for Apache Helix 0.9.8
+ -----
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/guides/mini/guide-apt-format.html
+
+Release Notes for Apache Helix 0.9.8
+
+ The Apache Helix team would like to announce the release of Apache Helix 0.9.8.
+
+ This is the twenty-third release under the Apache umbrella, and the sixteenth as a top-level project.
Review comment:
Nit: 23rd and 16th?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1465: Adding release notes for 0.9.8 (hotfix).
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1465:
URL: https://github.com/apache/helix/pull/1465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org