[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3584: adds more automated TP tests so the data can build from a clean db

[GitBox <gi...@apache.org>]

mitchell852 commented on a change in pull request #3584: adds more automated TP tests so the data can build from a clean db
URL: https://github.com/apache/trafficcontrol/pull/3584#discussion_r286131440
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/division/form.division.tpl.html
 ##########
 @@ -31,13 +31,12 @@
     <div class="x_content">
         <br>
         <form name="divisionForm" class="form-horizontal form-label-left" novalidate>
-            <div class="form-group" ng-class="{'has-error': hasError(divisionForm[prop.name]), 'has-feedback': hasError(divisionForm[prop.name])}" ng-repeat="prop in props">
-                <label class="control-label col-md-2 col-sm-2 col-xs-12">{{labelize(prop.name)}} <span ng-show="prop.required">*</span></label>
+            <div class="form-group" ng-class="{'has-error': hasError(divisionForm.name), 'has-feedback': hasError(divisionForm.name)}">
+                <label class="control-label col-md-2 col-sm-2 col-xs-12">Name *</label>
 
 Review comment:
   unrelated to this PR. you have a tech debt issue for fixing this globally, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services