[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #1166: HDDS-3914. Remove LevelDB configuration option for DN Metastore

[GitBox <gi...@apache.org>]

hanishakoneru commented on a change in pull request #1166:
URL: https://github.com/apache/hadoop-ozone/pull/1166#discussion_r452391946



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java
##########
@@ -186,8 +186,8 @@ private void checkContainerFile() throws IOException {
     }
 
     dbType = onDiskContainerData.getContainerDBType();
-    if (!dbType.equals(OZONE_METADATA_STORE_IMPL_ROCKSDB) &&
-        !dbType.equals(OZONE_METADATA_STORE_IMPL_LEVELDB)) {
+    if (!dbType.equals(CONTAINER_DB_TYPE_ROCKSDB) &&

Review comment:
       We are deprecating LevelDB support. I kept it there in case there are old containers using LevelDB.
   
   I am up for removing LevelDB support completely. I think it is safe to assume that there would not be a Container using LevelDB.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org