[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7145: Enhance the Http Firehose to work with URIs requiring basic authentication

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7145: Enhance the Http Firehose to work with URIs requiring basic authentication
URL: https://github.com/apache/incubator-druid/pull/7145#discussion_r270989619
 
 

 ##########
 File path: docs/content/ingestion/firehose.md
 ##########
 @@ -74,6 +74,28 @@ A sample http firehose spec is shown below:
 }
 ```
 
+The below configurations can be optionally used if the URIs specified in the spec require a Basic Authentication Header.
+Omitting these fields from your spec will result in HTTP requests with no Basic Authentication Header.
+
+|property|description|default|
+|--------|-----------|-------|
+|httpAuthenticationUsername|Username to use for authentication with specified URIs|None|
+|httpAuthenticationPassword|json object with a field called password containing the password to use for authentication with specified URIs|None|
 
 Review comment:
   nit: json -> JSON

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org