You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "songxiaosheng (via GitHub)" <gi...@apache.org> on 2023/03/20 11:39:55 UTC

[GitHub] [dubbo] songxiaosheng commented on a diff in pull request #11857: Code opt

songxiaosheng commented on code in PR #11857:
URL: https://github.com/apache/dubbo/pull/11857#discussion_r1141988326


##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/MetricsKeyWrapper.java:
##########
@@ -17,17 +17,28 @@
 
 package org.apache.dubbo.metrics.model;
 
+import java.util.Map;
+
 /**
  * Let {@link MetricsKey MetricsKey}  output dynamic, custom string content
  */
 public class MetricsKeyWrapper {
 
+    // Register、subscribe、notify etc

Review Comment:
   can use doc comment such as /* */



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org