You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/14 23:44:04 UTC

[GitHub] [spark] maropu commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions

maropu commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r505075740



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -90,7 +90,8 @@ trait BinaryArrayExpressionWithImplicitCast extends BinaryExpression
       > SELECT _FUNC_(NULL);
        -1
   """,
-  since = "1.5.0")
+  since = "1.5.0",
+  group = "array_funcs")
 case class Size(child: Expression, legacySizeOfNull: Boolean)
   extends UnaryExpression with ExpectsInputTypes {

Review comment:
       hm, I see. Another idea: how about making a group for more general cases, e.g., `collection_funcs`? cc: @HyukjinKwon 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org