You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Balázs Bence Sári <bs...@hortonworks.com> on 2017/01/20 18:30:44 UTC
Review Request 55777: Update quicklink.json files in stack
definitions with authenticated/sso features
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55777/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19655
https://issues.apache.org/jira/browse/AMBARI-19655
Repository: ambari
Description
-------
Existing quicklink definitions need to be updated with authenticatedness and sso-ness information wherever applicable.
E.g:
"links": [
{
"name": "atlas_dashboard",
"label": "Atlas Dashboard",
"url": "%@://%@:%@/#!/search?user.name=%@",
...
"attributes": [
"authenticated",
"sso"
],
...
}
]
Diffs
-----
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/quicklinks/quicklinks.json e86b665
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json 152ff57
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json b6f6a09
ambari-server/src/main/resources/common-services/RANGER/0.4.0/quicklinks/quicklinks.json ea8c378
ambari-server/src/main/resources/common-services/RANGER/0.5.0/quicklinks/quicklinks.json 3689ba9
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json ccc52bc
Diff: https://reviews.apache.org/r/55777/diff/
Testing
-------
Manually tested the change. Installed a cluster.
- Verified that attributes a returned by the API.
- Verified that attributes are respected when a quick links profile to show authenticated/sso links only is in effect
Thanks,
Bal�zs Bence S�ri
Re: Review Request 55777: Update quicklink.json files in stack
definitions with authenticated/sso features
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55777/#review162467
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 20, 2017, 7:30 p.m., Bal�zs Bence S�ri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55777/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 7:30 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19655
> https://issues.apache.org/jira/browse/AMBARI-19655
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Existing quicklink definitions need to be updated with authenticatedness and sso-ness information wherever applicable.
>
> E.g:
> "links": [
> {
> "name": "atlas_dashboard",
> "label": "Atlas Dashboard",
> "url": "%@://%@:%@/#!/search?user.name=%@",
> ...
> "attributes": [
> "authenticated",
> "sso"
> ],
> ...
> }
> ]
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/quicklinks/quicklinks.json e86b665
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json 152ff57
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json b6f6a09
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/quicklinks/quicklinks.json ea8c378
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/quicklinks/quicklinks.json 3689ba9
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json ccc52bc
>
> Diff: https://reviews.apache.org/r/55777/diff/
>
>
> Testing
> -------
>
> Manually tested the change. Installed a cluster.
> - Verified that attributes a returned by the API.
> - Verified that attributes are respected when a quick links profile to show authenticated/sso links only is in effect
>
>
> Thanks,
>
> Bal�zs Bence S�ri
>
>
Re: Review Request 55777: Update quicklink.json files in stack
definitions with authenticated/sso features
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55777/#review162489
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Jan. 20, 2017, 6:30 p.m., Bal�zs Bence S�ri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55777/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 6:30 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19655
> https://issues.apache.org/jira/browse/AMBARI-19655
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Existing quicklink definitions need to be updated with authenticatedness and sso-ness information wherever applicable.
>
> E.g:
> "links": [
> {
> "name": "atlas_dashboard",
> "label": "Atlas Dashboard",
> "url": "%@://%@:%@/#!/search?user.name=%@",
> ...
> "attributes": [
> "authenticated",
> "sso"
> ],
> ...
> }
> ]
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/quicklinks/quicklinks.json e86b665
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json 152ff57
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json b6f6a09
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/quicklinks/quicklinks.json ea8c378
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/quicklinks/quicklinks.json 3689ba9
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json ccc52bc
>
> Diff: https://reviews.apache.org/r/55777/diff/
>
>
> Testing
> -------
>
> Manually tested the change. Installed a cluster.
> - Verified that attributes a returned by the API.
> - Verified that attributes are respected when a quick links profile to show authenticated/sso links only is in effect
>
>
> Thanks,
>
> Bal�zs Bence S�ri
>
>
Re: Review Request 55777: Update quicklink.json files in stack
definitions with authenticated/sso features
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55777/#review162460
-----------------------------------------------------------
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 20, 2017, 6:30 p.m., Bal�zs Bence S�ri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55777/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 6:30 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19655
> https://issues.apache.org/jira/browse/AMBARI-19655
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Existing quicklink definitions need to be updated with authenticatedness and sso-ness information wherever applicable.
>
> E.g:
> "links": [
> {
> "name": "atlas_dashboard",
> "label": "Atlas Dashboard",
> "url": "%@://%@:%@/#!/search?user.name=%@",
> ...
> "attributes": [
> "authenticated",
> "sso"
> ],
> ...
> }
> ]
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/quicklinks/quicklinks.json e86b665
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json 152ff57
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json b6f6a09
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/quicklinks/quicklinks.json ea8c378
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/quicklinks/quicklinks.json 3689ba9
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json ccc52bc
>
> Diff: https://reviews.apache.org/r/55777/diff/
>
>
> Testing
> -------
>
> Manually tested the change. Installed a cluster.
> - Verified that attributes a returned by the API.
> - Verified that attributes are respected when a quick links profile to show authenticated/sso links only is in effect
>
>
> Thanks,
>
> Bal�zs Bence S�ri
>
>
Re: Review Request 55777: Update quicklink.json files in stack
definitions with authenticated/sso features
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55777/#review162466
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Jan. 20, 2017, 6:30 p.m., Bal�zs Bence S�ri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55777/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 6:30 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19655
> https://issues.apache.org/jira/browse/AMBARI-19655
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Existing quicklink definitions need to be updated with authenticatedness and sso-ness information wherever applicable.
>
> E.g:
> "links": [
> {
> "name": "atlas_dashboard",
> "label": "Atlas Dashboard",
> "url": "%@://%@:%@/#!/search?user.name=%@",
> ...
> "attributes": [
> "authenticated",
> "sso"
> ],
> ...
> }
> ]
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/quicklinks/quicklinks.json e86b665
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json 152ff57
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json b6f6a09
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/quicklinks/quicklinks.json ea8c378
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/quicklinks/quicklinks.json 3689ba9
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json ccc52bc
>
> Diff: https://reviews.apache.org/r/55777/diff/
>
>
> Testing
> -------
>
> Manually tested the change. Installed a cluster.
> - Verified that attributes a returned by the API.
> - Verified that attributes are respected when a quick links profile to show authenticated/sso links only is in effect
>
>
> Thanks,
>
> Bal�zs Bence S�ri
>
>