You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/08 23:26:57 UTC

[GitHub] [spark] yeshengm opened a new pull request #25080: [SPARK-28306] Fix idempotence for optimizer rule NormalizeFloatingNumbers

yeshengm opened a new pull request #25080: [SPARK-28306] Fix idempotence for optimizer rule NormalizeFloatingNumbers
URL: https://github.com/apache/spark/pull/25080
 
 
   ## What changes were proposed in this pull request?
   The optimizer rule `NormalizeFloatingNumbers` is not idempotent. It will generate multiple `NormalizeNaNAndZero` and `ArrayTransform` expression nodes for multiple runs. This patch fixed this non-idempotence by adding a marking tag above normalized expressions. It also adds missing UTs for `NormalizeFloatingNumbers`.
   
   ## How was this patch tested?
   New UTs.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org