You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/26 09:07:51 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6698: driver/power:add ioctl cmd for voltage info and protocol and add update event mask

pkarashchenko commented on code in PR #6698:
URL: https://github.com/apache/incubator-nuttx/pull/6698#discussion_r929715929


##########
include/nuttx/power/battery_charger.h:
##########
@@ -125,7 +125,11 @@ struct battery_charger_operations_s
 
   /* Get the actual output voltage for charging */
 
-  int (*get_voltage)(struct battery_charger_dev_s *dev, int *value);
+  int (*get_voltage)(struct battery_charger_dev_s *dev, FAR int *value);

Review Comment:
   In general all `struct battery_charger_operations_s` is missing `CODE` and `FAR`, but let's add it in the separate PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org