You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2026/10/20 01:39:49 UTC

[PR] feat(evaluation): open a judged span's trace from the store its record names [skywalking-horizon-ui]

wu-sheng opened a new pull request, #204:
URL: https://github.com/apache/skywalking-horizon-ui/pull/204

   ## Why
   
   An evaluation record's `traceRef.type` used to say only how the judged span is addressed, and `OTLP` covered spans in two different OAP stores: OTLP spans stored as received, and Zipkin spans (from the Zipkin receiver, or OTLP converted with `otlpTraceStorage: zipkin`). Horizon opened every `OTLP` record from the Zipkin store, so on OAP's default storage the trace link and **Pick span…** found nothing. apache/skywalking#14152 (merged) makes `type` name the store — `SKYWALKING_NATIVE`, `OTLP` or `ZIPKIN` — decided per span when it arrives. Horizon now reads each trace from the store its record names, with no probing and no fallback. Supersedes #199.
   
   ## What
   
   - **Trace link and Pick span…** follow `traceRef.type`: native → native waterfall, `OTLP` → the TraceQL popout over OAP's OTLP datasource with the judged span selected (`traceqlSpanId`), `ZIPKIN` → the Zipkin popout. The picker marks GenAI spans in each store's own span model (`genAIContextOfOTLPSpan` for TraceQL spans).
   - **Trace store condition**: SkyWalking Native, OTLP or Zipkin. OAP matches it exactly, so the docs say to pick the store the trace was written to.
   - **A missing TraceQL store is not a missing trace.** The TraceQL trace route answers `configured: false` for a source with no TraceQL URL and `served: false` when OAP answers 404 on the datasource path (the build-info probe tells that apart from a trace OAP has no record of); the popout and the picker name the OAP switch and Horizon path key to check.
   - The TraceQL popout re-reads a trace that is still landing, as the native and Zipkin popouts do; the shared retry moved to `components/primitives/` and takes the identity of what it reads, so a view reused for another trace gets its own budget.
   - `useResultTracePopout` moved into `layer/evaluation-record/`, its only user.
   - Docs (`operate/genai-evaluation.md`), the 1.1.0 changelog entries, the BFF guide's TraceQL notes, and two new UI strings in all 8 locales.
   
   **e2e**
   - OAP pinned at the #14152 merge (`f34b9c7ef0`).
   - `genai` adds TraceQL with the OTLP datasource, the Zipkin receiver and query modules, and a caller exporting Zipkin; readiness checks for `ZIPKIN` records and for each store's trace read; specs that open an OTLP and a Zipkin record and narrow the trace-id condition to one span of each.
   - `core`: the endpoint specs pick the fixture's endpoint by name. Since apache/skywalking#14122, OAP lists endpoints known only from logs or cross-thread spans (`HikariCP/Connection/getConnection` here), which carry no endpoint metrics; the tab can open on one of them.
   
   ## Validation
   
   - `pnpm -r run type-check`, both builds, `pnpm lint` (incl. i18n parity, docs links, source budget), `pnpm license:check`, UI unit tests (1546) and BFF unit tests (2176) — green.
   - Live OAP, local e2e harness (`make run`) on the pinned `f34b9c7ef0` image: `genai` 10/10 verify cases with 9/9 browser specs (all three stores), `core` 11/11 with 83/84 browser specs (one pre-existing skip), `ai-agent` 5/5 with 9/9. The remaining cases run in CI.
   - Wire, against an OAP built from #14152: records carry all three types through the BFF; an OTLP trace reads through TraceQL with its judged span and `gen_ai.*` attributes, a Zipkin trace through the Zipkin API; a `ZIPKIN` filter finds the trace's records and an `OTLP` filter on the same trace finds none; a TraceQL datasource OAP does not enable answers `served: false`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(evaluation): open a judged span's trace from the store its record names [skywalking-horizon-ui]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #204:
URL: https://github.com/apache/skywalking-horizon-ui/pull/204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org