[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9054: [database] new, select star API migration

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #9054: [database] new, select star API migration
URL: https://github.com/apache/incubator-superset/pull/9054#discussion_r374228054
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1958,11 +1958,26 @@ def extra_table_metadata(self, database_id, table_name, schema):
     @expose("/select_star/<database_id>/<table_name>/<schema>")
     @event_logger.log_this
     def select_star(self, database_id, table_name, schema=None):
-        mydb = db.session.query(models.Database).get(database_id)
+        logging.warning(
+            "This API endpoint is deprecated and will be removed in version 1.0.0"
 
 Review comment:
   Let's include the actual endpoint being deprecated in the warning - I imagine there will be a number deprecated for 1.0 and it would be helpful for users not to have to dig through the logs to understand which endpoint is issuing the warning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org