[GitHub] [logging-log4j2] jvz edited a comment on pull request #416: [LOG4J2-2919] Call ReliabilityStrategy's beforeStopAppenders() method before stopping AsyncAppender

[GitBox <gi...@apache.org>]

jvz edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689613155


   I usually use https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html for chaining together asynchronous things (particularly in unit tests) where you can await the latch where you'd normally sleep, and countdown the latch in places where work is completed. However, since concurrency bugs like that are difficult to test sometimes, I think it'd also be acceptable if you include the detailed reproduction steps in the Jira ticket so that I can try writing one. I may be able to help you design a unit test here, though, depending on how comfortable you are with concurrency code.
   
   Edit: now this won't be necessary to merge this, but it sounds like we might want to figure out a test for 1121 if possible. If you can describe a test scenario there, I can help design or write that test as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org