You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/28 00:29:29 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #2165: Spark: Extend write distribution and ordering with more options

rdblue commented on a change in pull request #2165:
URL: https://github.com/apache/iceberg/pull/2165#discussion_r565736813



##########
File path: spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -69,7 +69,18 @@ statement
     : CALL multipartIdentifier '(' (callArgument (',' callArgument)*)? ')'                  #call
     | ALTER TABLE multipartIdentifier ADD PARTITION FIELD transform (AS name=identifier)?   #addPartitionField
     | ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform                        #dropPartitionField
-    | ALTER TABLE multipartIdentifier WRITE ORDERED BY order                                #setTableOrder
+    | ALTER TABLE multipartIdentifier WRITE
+        writeDistributionSpec?

Review comment:
       Do we need to require `distributed by` before `ordered by`?
   
   I think it would be more natural to use `WRITE UNORDERED DISTRIBUTED BY PARTITION`. In general, I think it makes sense to avoid order requirements for orthogonal clauses.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org