You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/12/24 04:52:57 UTC

[GitHub] spark pull request #20068: [SPARK-17916][SQL] Fix empty string being parsed ...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20068#discussion_r158593580
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala ---
    @@ -152,7 +152,7 @@ class CSVOptions(
         writerSettings.setIgnoreLeadingWhitespaces(ignoreLeadingWhiteSpaceFlagInWrite)
         writerSettings.setIgnoreTrailingWhitespaces(ignoreTrailingWhiteSpaceFlagInWrite)
         writerSettings.setNullValue(nullValue)
    -    writerSettings.setEmptyValue(nullValue)
    +    writerSettings.setEmptyValue("")
    --- End diff --
    
    Can we simply expose this as an option and keep the previous behaviour if this option is not set explicitly by the user?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org