You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/13 03:04:06 UTC

[GitHub] [rocketmq] dongeforever commented on pull request #4099: [ISSUE #4098]Optimized the algorithm of trace message send.

dongeforever commented on PR #4099:
URL: https://github.com/apache/rocketmq/pull/4099#issuecomment-1097502705

   @dugenkui03 I found another issue.
   In the AsyncAppenderRequest, the max message size is 128000.
   So If the byte size of the accumulated  TraceContext  is more than 128000, it cannot reduce the RPC to improve the performance, but cause delay.
   
   So the algorithm may need to consider the byte size too. If the byte size is enough, it should be scheduled immediately.
   
   BTW, the data topic generated by "sendTraceData" is not used in  "sendTraceDataByMQ".
   
   Maybe we need to clarify the design of topic mechanism for trace.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org