You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/14 22:26:20 UTC

[GitHub] [superset] eschutho commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript

eschutho commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r651318186



##########
File path: superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -134,6 +136,19 @@ export default class SqlEditorLeftBar extends React.PureComponent {
     this.props.actions.addTable(this.props.queryEditor, tableName, schemaName);
   }
 
+  renderExpandIconWithTooltip = ({ isActive }) => (
+    <IconTooltip
+      style={{ transform: 'rotate(90deg)' }}

Review comment:
       can we use the css prop here and below instead of `style`? It's a pattern we've been migrating to. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org