You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/28 05:14:14 UTC

[GitHub] [shardingsphere] TeslaCN opened a new pull request, #18652: Support receiving COM_STMT_SEND_LONG_DATA in MySQL Proxy

TeslaCN opened a new pull request, #18652:
URL: https://github.com/apache/shardingsphere/pull/18652

   Fixes #17827.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #18652: Support COM_STMT_SEND_LONG_DATA in MySQL Proxy

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18652:
URL: https://github.com/apache/shardingsphere/pull/18652


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #18652: Support receiving COM_STMT_SEND_LONG_DATA in MySQL Proxy

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18652:
URL: https://github.com/apache/shardingsphere/pull/18652#issuecomment-1168256981

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18652?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18652](https://codecov.io/gh/apache/shardingsphere/pull/18652?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e65fe7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b5070e7a0e66b8a36967f9d2a77a93a317c37b18?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5070e7) will **increase** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18652      +/-   ##
   ============================================
   + Coverage     59.41%   59.43%   +0.01%     
     Complexity     2259     2259              
   ============================================
     Files          3727     3729       +2     
     Lines         54726    54748      +22     
     Branches       9313     9316       +3     
   ============================================
   + Hits          32516    32540      +24     
   + Misses        19469    19467       -2     
     Partials       2741     2741              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18652?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...d/query/binary/MySQLComStmtSendLongDataPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9NeVNRTENvbVN0bXRTZW5kTG9uZ0RhdGFQYWNrZXQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...uery/binary/execute/MySQLComStmtExecutePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9leGVjdXRlL015U1FMQ29tU3RtdEV4ZWN1dGVQYWNrZXQuamF2YQ==) | `93.10% <100.00%> (+0.79%)` | :arrow_up: |
   | [...end/mysql/command/MySQLCommandExecutorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvTXlTUUxDb21tYW5kRXhlY3V0b3JGYWN0b3J5LmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ntend/mysql/command/MySQLCommandPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvTXlTUUxDb21tYW5kUGFja2V0RmFjdG9yeS5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...query/binary/MySQLComStmtSendLongDataExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L015U1FMQ29tU3RtdFNlbmRMb25nRGF0YUV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ry/binary/execute/MySQLComStmtExecuteExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L2V4ZWN1dGUvTXlTUUxDb21TdG10RXhlY3V0ZUV4ZWN1dG9yLmphdmE=) | `95.91% <100.00%> (+0.08%)` | :arrow_up: |
   | [.../query/binary/reset/MySQLComStmtResetExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L3Jlc2V0L015U1FMQ29tU3RtdFJlc2V0RXhlY3V0b3IuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [.../manager/ShardingSphereDistributedLockManager.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL21hbmFnZXIvU2hhcmRpbmdTcGhlcmVEaXN0cmlidXRlZExvY2tNYW5hZ2VyLmphdmE=) | `82.75% <0.00%> (+0.94%)` | :arrow_up: |
   | [.../db/protocol/mysql/payload/MySQLPacketPayload.java](https://codecov.io/gh/apache/shardingsphere/pull/18652/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BheWxvYWQvTXlTUUxQYWNrZXRQYXlsb2FkLmphdmE=) | `96.22% <0.00%> (+2.83%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18652?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18652?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a49ab8...6e65fe7](https://codecov.io/gh/apache/shardingsphere/pull/18652?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #18652: Support receiving COM_STMT_SEND_LONG_DATA in MySQL Proxy

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #18652:
URL: https://github.com/apache/shardingsphere/pull/18652#issuecomment-1168270583

   There may be concurrent problem if MySQL Proxy uses `UserExecutorGroup`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org